Commit 2d44e6e5 authored by Christos Froussios's avatar Christos Froussios Committed by Commit Bot

[Sheriff] Disable some tests in ArcRobotAccountAuthServiceTest and...

[Sheriff] Disable some tests in ArcRobotAccountAuthServiceTest and ArcAuthServiceChildAccountTest on MSan

Several tests in these suits have become flaky
on non_single_process_mash_browser_tests
on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests

TBR=khmel@chromium.org

Bug: 934796
Change-Id: I41f8af80d207d820ba234e0854bf53fce52d93ee
Reviewed-on: https://chromium-review.googlesource.com/c/1483020Reviewed-by: default avatarChristos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634685}
parent 49caf1e1
......@@ -807,8 +807,16 @@ IN_PROC_BROWSER_TEST_F(ArcRobotAccountAuthServiceTest, GetDemoAccount) {
EXPECT_FALSE(auth_instance().account_info()->is_managed);
}
#if defined(MEMORY_SANITIZER)
#define MAYBE_GetOfflineDemoAccountViaDeprecatedApi \
DISABLED_GetOfflineDemoAccountViaDeprecatedApi
#else
#define MAYBE_GetOfflineDemoAccountViaDeprecatedApi \
GetOfflineDemoAccountViaDeprecatedApi
#endif
// TODO(crbug.com/934796) The test is flaky on ChromeOs MSan.
IN_PROC_BROWSER_TEST_F(ArcRobotAccountAuthServiceTest,
GetOfflineDemoAccountViaDeprecatedApi) {
MAYBE_GetOfflineDemoAccountViaDeprecatedApi) {
chromeos::DemoSession::SetDemoConfigForTesting(
chromeos::DemoSession::DemoModeConfig::kOffline);
chromeos::DemoSession::StartIfInDemoMode();
......@@ -828,7 +836,14 @@ IN_PROC_BROWSER_TEST_F(ArcRobotAccountAuthServiceTest,
EXPECT_TRUE(auth_instance().account_info()->is_managed);
}
IN_PROC_BROWSER_TEST_F(ArcRobotAccountAuthServiceTest, GetOfflineDemoAccount) {
#if defined(MEMORY_SANITIZER)
#define MAYBE_GetOfflineDemoAccount DISABLED_GetOfflineDemoAccount
#else
#define MAYBE_GetOfflineDemoAccount GetOfflineDemoAccount
#endif
// TODO(crbug.com/934796) The test is flaky on ChromeOS MSan.
IN_PROC_BROWSER_TEST_F(ArcRobotAccountAuthServiceTest,
MAYBE_GetOfflineDemoAccount) {
chromeos::DemoSession::SetDemoConfigForTesting(
chromeos::DemoSession::DemoModeConfig::kOffline);
chromeos::DemoSession::StartIfInDemoMode();
......@@ -848,8 +863,17 @@ IN_PROC_BROWSER_TEST_F(ArcRobotAccountAuthServiceTest, GetOfflineDemoAccount) {
EXPECT_TRUE(auth_instance().account_info()->is_managed);
}
IN_PROC_BROWSER_TEST_F(ArcRobotAccountAuthServiceTest,
GetDemoAccountOnAuthTokenFetchFailureViaDeprecatedApi) {
#if defined(MEMORY_SANITIZER)
#define MAYBE_GetDemoAccountOnAuthTokenFetchFailureViaDeprecatedApi \
DISABLED_GetDemoAccountOnAuthTokenFetchFailureViaDeprecatedApi
#else
#define MAYBE_GetDemoAccountOnAuthTokenFetchFailureViaDeprecatedApi \
GetDemoAccountOnAuthTokenFetchFailureViaDeprecatedApi
#endif
// TODO(crbug.com/934796) The test is flaky on ChromeOS MSan.
IN_PROC_BROWSER_TEST_F(
ArcRobotAccountAuthServiceTest,
MAYBE_GetDemoAccountOnAuthTokenFetchFailureViaDeprecatedApi) {
chromeos::DemoSession::SetDemoConfigForTesting(
chromeos::DemoSession::DemoModeConfig::kOnline);
chromeos::DemoSession::StartIfInDemoMode();
......@@ -922,8 +946,16 @@ class ArcAuthServiceChildAccountTest : public ArcAuthServiceTest {
// Tests that when ARC requests account info for a child account, via
// |RequestAccountInfoDeprecated| and Chrome supplies the info configured in
// SetAccountAndProfile() above.
#if defined(MEMORY_SANITIZER)
#define MAYBE_ChildAccountFetchViaDeprecatedApi \
DISABLED_ChildAccountFetchViaDeprecatedApi
#else
#define MAYBE_ChildAccountFetchViaDeprecatedApi \
ChildAccountFetchViaDeprecatedApi
#endif
// TODO(crbug.com/934796) The test is flaky on ChromeOS MSan.
IN_PROC_BROWSER_TEST_F(ArcAuthServiceChildAccountTest,
ChildAccountFetchViaDeprecatedApi) {
MAYBE_ChildAccountFetchViaDeprecatedApi) {
SetAccountAndProfile(user_manager::USER_TYPE_CHILD);
EXPECT_TRUE(profile()->IsChild());
test_url_loader_factory().AddResponse(arc::kAuthTokenExchangeEndPoint,
......@@ -945,7 +977,14 @@ IN_PROC_BROWSER_TEST_F(ArcAuthServiceChildAccountTest,
// Tests that when ARC requests account info for a child account and
// Chrome supplies the info configured in SetAccountAndProfile() above.
IN_PROC_BROWSER_TEST_F(ArcAuthServiceChildAccountTest, ChildAccountFetch) {
#if defined(MEMORY_SANITIZER)
#define MAYBE_ChildAccountFetch DISABLED_ChildAccountFetch
#else
#define MAYBE_ChildAccountFetch ChildAccountFetch
#endif
// TODO(crbug.com/934796) The test is flaky on ChromeOS MSan.
IN_PROC_BROWSER_TEST_F(ArcAuthServiceChildAccountTest,
MAYBE_ChildAccountFetch) {
SetAccountAndProfile(user_manager::USER_TYPE_CHILD);
EXPECT_TRUE(profile()->IsChild());
test_url_loader_factory().AddResponse(arc::kAuthTokenExchangeEndPoint,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment