[android] Hide <select> dropdown on outside tap.

Outside tap should hide <select> dropdowns, but not dropdowns associated
with input fields. Tapping on an input field should not hide the
associated autofill or password generation popup.

BUG=430543

Review URL: https://codereview.chromium.org/932493003

Cr-Commit-Position: refs/heads/master@{#316641}

chrome/android/java/src/org/chromium/chrome/browser/autofill/PasswordGenerationPopupBridge.java

@@ -66,6 +66,7 @@ public class PasswordGenerationPopupBridge implements AdapterView.OnItemClickLis
             mPopup = new DropdownPopupWindow(mContext, containerViewDelegate);
             mPopup.setOnItemClickListener(this);
             mPopup.setOnDismissListener(this);
+            mPopup.disableHideOnOutsideTap();
         }
         mAnchorWidth = 0;
     }

ui/android/java/src/org/chromium/ui/DropdownPopupWindow.java

@@ -134,7 +134,26 @@ public class DropdownPopupWindow extends ListPopupWindow {
         getListView().setDividerHeight(0);
         ApiCompatibilityUtils.setLayoutDirection(getListView(),
                 mRtl ? View.LAYOUT_DIRECTION_RTL : View.LAYOUT_DIRECTION_LTR);
+    }
+
+    @Override
+    public void setOnDismissListener(PopupWindow.OnDismissListener listener) {
+        mOnDismissListener = listener;
+    }
 
+    /**
+     * Sets the text direction in the dropdown. Should be called before show().
+     * @param isRtl If true, then dropdown text direciton is right to left.
+     */
+    public void setRtl(boolean isRtl) {
+        mRtl = isRtl;
+    }
+
+    /**
+     * Disable hiding on outside tap so that tapping on a text input field associated with the popup
+     * will not hide the popup.
+     */
+    public void disableHideOnOutsideTap() {
         // HACK: The ListPopupWindow's mPopup automatically dismisses on an outside tap. There's
         // no way to override it or prevent it, except reaching into ListPopupWindow's hidden
         // API. This allows the C++ controller to completely control showing/hiding the popup.
@@ -150,19 +169,6 @@ public class DropdownPopupWindow extends ListPopupWindow {
         }
     }
 
-    @Override
-    public void setOnDismissListener(PopupWindow.OnDismissListener listener) {
-        mOnDismissListener = listener;
-    }
-
-    /**
-     * Sets the text direction in the dropdown. Should be called before show().
-     * @param isRtl If true, then dropdown text direciton is right to left.
-     */
-    public void setRtl(boolean isRtl) {
-        mRtl = isRtl;
-    }
-
     /**
      * Measures the width of the list content. The adapter should not be null.
      * @return The popup window width in pixels.

ui/android/java/src/org/chromium/ui/autofill/AutofillPopup.java

@@ -67,6 +67,7 @@ public class AutofillPopup extends DropdownPopupWindow implements AdapterView.On
 
         setOnItemClickListener(this);
         setOnDismissListener(this);
+        disableHideOnOutsideTap();
     }
 
     /**