SettingsSplit: Remove unnecessary 'preprocess' attributes from grd
By searching the settings/chromeos folder [1] for the string "<if" [2], I determined that there are only 4 files in it that have conditional tags that require preprocessing, namely -settings/chromeos/os_settings.html -settings/chromeos/os_about_page/os_about_page.js -settings/chromeos/os_about_page/os_about_page.html -settings/chromeos/os_privacy_page/os_privacy_page.html I suspect that the preprocess attributes were just not deleted when those files were branched from browser settings. This CL removes the preprocess=true attribute from every file from the chromeos folder [1] in os_settings_resources.grd other than the 4 aforementioned files. It also adds preprocess="true" to os_privacy_page.html, which has "<if expr..." conditional content but did not have the attribute. [1] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/chromeos/ [2] http://screen/X7uR9d0LJPf Bug: 987384 Change-Id: Ifcf42add56ac4b79a41dfe783678236e58b5584c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715261Reviewed-by:Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
May Lippert <maybelle@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#680615}
Showing
Please register or sign in to comment