Only consider PasswordFromManager which HasCompletedMatching when provisionally saving passwords
In PasswordManager::ProvisionallySavePassword, PasswordFormManager instances are sought, which could be managing the form being saved. Some of those managers may not be ready, because they still did not complete matching against the PasswordStore. There might also be more form managers suitable for the form being saved, with some having completed the matching, and some not. Currently, the code first finds the first suitable form manager, and then drops it if it has not completed matching. This ignores the fact that there might be a second choice form manager, which has completed matching. This happens currently on live.com (see the bug). This CL ignores form managers which did not complete matching when looking for a suitable form manager for the form being saved. This CL also improves a poorly phrased log message related to the situation when form managers have not completed matching. BUG=367768 Review URL: https://codereview.chromium.org/331593008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282935 0039d316-1c4b-4281-b951-d872f2087c98
Showing
Please register or sign in to comment