Commit 2d9c589f authored by Charlie Andrews's avatar Charlie Andrews Committed by Commit Bot

Remove TODO about removing BLINK_PLATFORM_EXPORT on WebInputEventDeleter

BLINK_PLATFORM_EXPORT can't be safely removed without causing a linker
error on Windows and this fact isn't going away.

Bug: 691714
Change-Id: Ie2399c50877e16fa80f9cb3ebe455c56493e6cce
Reviewed-on: https://chromium-review.googlesource.com/c/1343291
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: default avatarNico Weber <thakis@chromium.org>
Reviewed-by: default avatarHans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609857}
parent 51748f6b
...@@ -42,8 +42,6 @@ class BLINK_PLATFORM_EXPORT WebCoalescedInputEvent { ...@@ -42,8 +42,6 @@ class BLINK_PLATFORM_EXPORT WebCoalescedInputEvent {
std::vector<const WebInputEvent*> GetPredictedEventsPointers() const; std::vector<const WebInputEvent*> GetPredictedEventsPointers() const;
private: private:
// TODO(hans): Remove this once clang-cl knows to not inline dtors that
// call operator(), https://crbug.com/691714
struct BLINK_PLATFORM_EXPORT WebInputEventDeleter { struct BLINK_PLATFORM_EXPORT WebInputEventDeleter {
void operator()(blink::WebInputEvent*) const; void operator()(blink::WebInputEvent*) const;
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment