Commit 2da1afb0 authored by yhirano@chromium.org's avatar yhirano@chromium.org

[ServiceWorker] Use appopriate type parameters for WebCallbacks (3/3)


 - WebServiceWorkerRegistration* (ownership transferred)
  => WebPassOwnPtr<WebServiceWorkerRegistration>
 - WebVector<WebServiceWorkerRegistration*> (ownership transferred)
  => WebPassOwnPtr<WebVector<WebServiceWorkerRegistration*>>
 - WebServiceWorkerError* (ownership transferred)
  => const WebServiceWorkerError&

1/3: https://codereview.chromium.org/1312343004/
2/3: https://codereview.chromium.org/1318953002/
3/3: https://codereview.chromium.org/1316293002/

BUG=493531, 525340

Review URL: https://codereview.chromium.org/1316293002

git-svn-id: svn://svn.chromium.org/blink/trunk@201351 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent 1c727793
...@@ -52,34 +52,12 @@ public: ...@@ -52,34 +52,12 @@ public:
// events. Must be cleared before the client becomes invalid. // events. Must be cleared before the client becomes invalid.
virtual void setClient(WebServiceWorkerProviderClient*) { } virtual void setClient(WebServiceWorkerProviderClient*) { }
class WebServiceWorkerRegistrationCallbacks : public WebCallbacks<WebPassOwnPtr<WebServiceWorkerRegistration>, const WebServiceWorkerError&> { using WebServiceWorkerRegistrationCallbacks = WebCallbacks<WebPassOwnPtr<WebServiceWorkerRegistration>, const WebServiceWorkerError&>;
public: using WebServiceWorkerGetRegistrationCallbacks = WebCallbacks<WebPassOwnPtr<WebServiceWorkerRegistration>, const WebServiceWorkerError&>;
void onSuccess(WebServiceWorkerRegistration* r) { onSuccess(adoptWebPtr(r)); } // Each element's ownership is transferred.
void onError(WebServiceWorkerError* e) // TODO(yhirano): Consider using vector<scoped_ptr<>>.
{ using WebServiceWorkerGetRegistrationsCallbacks = WebCallbacks<WebPassOwnPtr<WebVector<WebServiceWorkerRegistration*>>, const WebServiceWorkerError&>;
onError(*e); using WebServiceWorkerGetRegistrationForReadyCallbacks = WebCallbacks<WebPassOwnPtr<WebServiceWorkerRegistration>, void>;
delete e;
}
virtual void onSuccess(WebPassOwnPtr<WebServiceWorkerRegistration>) = 0;
virtual void onError(const WebServiceWorkerError&) = 0;
};
using WebServiceWorkerGetRegistrationCallbacks = WebServiceWorkerRegistrationCallbacks;
class WebServiceWorkerGetRegistrationsCallbacks : public WebCallbacks<WebPassOwnPtr<WebVector<WebServiceWorkerRegistration*>>, const WebServiceWorkerError&> {
public:
void onSuccess(WebVector<WebServiceWorkerRegistration*>* r) { onSuccess(adoptWebPtr(r)); }
void onError(WebServiceWorkerError* e)
{
onError(*e);
delete e;
}
virtual void onSuccess(WebPassOwnPtr<WebVector<WebServiceWorkerRegistration*>>) = 0;
virtual void onError(const WebServiceWorkerError&) = 0;
};
class WebServiceWorkerGetRegistrationForReadyCallbacks : public WebCallbacks<WebPassOwnPtr<WebServiceWorkerRegistration>, void> {
public:
void onSuccess(WebServiceWorkerRegistration* r) { onSuccess(adoptWebPtr(r)); }
virtual void onSuccess(WebPassOwnPtr<WebServiceWorkerRegistration>) = 0;
};
virtual void registerServiceWorker(const WebURL& pattern, const WebURL& scriptUrl, WebServiceWorkerRegistrationCallbacks*) { } virtual void registerServiceWorker(const WebURL& pattern, const WebURL& scriptUrl, WebServiceWorkerRegistrationCallbacks*) { }
virtual void getRegistration(const WebURL& documentURL, WebServiceWorkerGetRegistrationCallbacks*) { } virtual void getRegistration(const WebURL& documentURL, WebServiceWorkerGetRegistrationCallbacks*) { }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment