Commit 2da78a4a authored by Julien Isorce's avatar Julien Isorce Committed by Commit Bot

Reland "Skip GpuOESEGLImageTest on ATI proprietary driver"

This is a reland of ed312194

Original change's description:
> Skip GpuOESEGLImageTest on ATI proprietary driver
>
> Detect the GL_VENDOR string from the default GL implementation.
> If it is the ATI proprietary driver then do not switch to EGL/GLES2
> as there is a known bug and this driver crashes in eglInitialize
> instead of failing properly.
>
> BUG=822716
>
> Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: I00b883012c31867f938bf3f68440058738bb312b
> Reviewed-on: https://chromium-review.googlesource.com/966662
> Commit-Queue: Kenneth Russell <kbr@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#543735}

TBR=kbr@chromium.org

Bug: 822716
Change-Id: I5af29ab9ac904ee90ed7d9d114300935fe26be66
Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/966825
Commit-Queue: Julien Isorce <julien.isorce@chromium.org>
Reviewed-by: default avatarCorentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544198}
parent 3d6ecf14
......@@ -375,6 +375,15 @@ bool GpuCommandBufferTestEGL::InitializeEGLGLES2(int width, int height) {
return false;
}
gpu::GPUInfo gpu_info;
gpu::CollectContextGraphicsInfo(&gpu_info);
// See crbug.com/822716, the ATI proprietary driver has eglGetProcAddress
// but eglInitialize crashes with x11.
if (gpu_info.gl_vendor.find("ATI Technologies Inc.") != std::string::npos) {
LOG(INFO) << "Skip test, ATI proprietary driver crashes with egl/x11";
return false;
}
gl_reinitialized_ = true;
gl::init::ShutdownGL(false /* due_to_fallback */);
if (!GLTestHelper::InitializeGL(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment