Commit 2db2ac2b authored by Charlie Harrison's avatar Charlie Harrison Committed by Commit Bot

[ad-tagging] Persist IsAdResource across redirects

Bug: 827519
Change-Id: I395dcad4993ecad65ecf7b55d76e7004fc919d3c
Reviewed-on: https://chromium-review.googlesource.com/987915Reviewed-by: default avatarJosh Karlin <jkarlin@chromium.org>
Reviewed-by: default avatarNate Chapin <japhet@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548638}
parent dad18bcb
......@@ -165,6 +165,8 @@ std::unique_ptr<ResourceRequest> ResourceRequest::CreateRedirectRequest(
request->SetCheckForBrowserSideNavigation(CheckForBrowserSideNavigation());
request->SetWasDiscarded(WasDiscarded());
request->SetCORSPreflightPolicy(CORSPreflightPolicy());
if (IsAdResource())
request->SetIsAdResource();
return request;
}
......
......@@ -148,6 +148,14 @@ TEST(ResourceRequestTest, SetIsAdResource) {
EXPECT_FALSE(original.IsAdResource());
original.SetIsAdResource();
EXPECT_TRUE(original.IsAdResource());
// Should persist across redirects.
std::unique_ptr<ResourceRequest> redirect_request =
original.CreateRedirectRequest(
KURL("https://example.test/redirect"), original.HttpMethod(),
original.SiteForCookies(), original.HttpReferrer(),
original.GetReferrerPolicy(), original.GetSkipServiceWorker());
EXPECT_TRUE(redirect_request->IsAdResource());
}
} // namespace blink
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment