[iOS] Disable Text Zoom on iPad

Text Zoom does not work on iPad because the Javascript property used
to change the content size doesn't work on iPad in iOS 13.

Bug: 1061119
Change-Id: Icc46da8c2a6990388b72312eaa4d4fd5807bd29c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152812
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760068}

ios/chrome/browser/ui/popup_menu/BUILD.gn

@@ -135,6 +135,7 @@ source_set("unit_tests") {
     "//testing/gmock",
     "//testing/gtest",
     "//third_party/ocmock",
+    "//ui/base:base",
   ]
   configs += [ "//build/config/compiler:enable_arc" ]
 }

ios/chrome/browser/ui/popup_menu/popup_menu_mediator.mm

@@ -853,7 +853,8 @@ PopupMenuToolsItem* CreateTableViewItem(int titleID,
   [actionsArray addObject:self.findInPageItem];
 
   // Text Zoom
-  if (base::FeatureList::IsEnabled(web::kWebPageTextAccessibility)) {
+  if (!IsIPadIdiom() &&
+      base::FeatureList::IsEnabled(web::kWebPageTextAccessibility)) {
     self.textZoomItem = CreateTableViewItem(
         IDS_IOS_TOOLS_MENU_TEXT_ZOOM, PopupMenuActionTextZoom,
         @"popup_menu_text_zoom", kToolsMenuTextZoom);

ios/chrome/browser/ui/popup_menu/popup_menu_mediator_unittest.mm

@@ -42,6 +42,7 @@
 #include "testing/platform_test.h"
 #import "third_party/ocmock/OCMock/OCMock.h"
 #include "third_party/ocmock/gtest_support.h"
+#include "ui/base/device_form_factor.h"
 
 #if !defined(__has_feature) || !__has_feature(objc_arc)
 #error "This file requires ARC support."
@@ -368,7 +369,11 @@ TEST_F(PopupMenuMediatorTest, TestReadLaterDisabled) {
 }
 
 // Tests that the "Text Zoom..." button is disabled on non-HTML pages.
-TEST_F(PopupMenuMediatorTest, TextTextZoomDisabled) {
+TEST_F(PopupMenuMediatorTest, TestTextZoomDisabled) {
+  // This feature is currently disabled on iPad. See crbug.com/1061119.
+  if (ui::GetDeviceFormFactor() == ui::DEVICE_FORM_FACTOR_TABLET) {
+    return;
+  }
   base::test::ScopedFeatureList feature_list;
   feature_list.InitAndEnableFeature(web::kWebPageTextAccessibility);
 
@@ -388,3 +393,24 @@ TEST_F(PopupMenuMediatorTest, TextTextZoomDisabled) {
   web_state_->OnNavigationFinished(&context);
   EXPECT_TRUE(HasItem(consumer, kToolsMenuTextZoom, /*enabled=*/NO));
 }
+
+// Tests that this feature is disabled on iPad, no matter the state of the
+// Feature flag. See crbug.com/1061119.
+TEST_F(PopupMenuMediatorTest, TestTextZoomDisabledIPad) {
+  if (ui::GetDeviceFormFactor() != ui::DEVICE_FORM_FACTOR_TABLET) {
+    return;
+  }
+
+  base::test::ScopedFeatureList feature_list;
+  feature_list.InitAndEnableFeature(web::kWebPageTextAccessibility);
+
+  CreateMediator(PopupMenuTypeToolsMenu, /*is_incognito=*/NO,
+                 /*trigger_incognito_hint=*/NO);
+  mediator_.webStateList = web_state_list_.get();
+
+  FakePopupMenuConsumer* consumer = [[FakePopupMenuConsumer alloc] init];
+  mediator_.popupMenu = consumer;
+  FontSizeTabHelper::CreateForWebState(web_state_list_->GetWebStateAt(0));
+  SetUpActiveWebState();
+  EXPECT_FALSE(HasItem(consumer, kToolsMenuTextZoom, /*enabled=*/YES));
+}