Commit 2dcc6125 authored by Becky Zhou's avatar Becky Zhou Committed by Commit Bot

[Modern] Revert close icon "always" shown as action on custom toolbar

On History/Download/Bookmarks, if we set close icon to "always" shown
as action, the other items can be collapsed into an overflow menu that
appears to the right of the close icon. We should temporarily set the
showAsAction back to "ifRoom" until we figure out a better way to
customize collapsing the items into an overflow menu.

Bug: 849849
Change-Id: Ic94f8d9071dc0295ec5adc10e36ab74eb4a2150b
Reviewed-on: https://chromium-review.googlesource.com/1114307Reviewed-by: default avatarTheresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570277}
parent 0ec6d6d5
...@@ -25,7 +25,7 @@ ...@@ -25,7 +25,7 @@
android:id="@+id/close_menu_id" android:id="@+id/close_menu_id"
android:icon="@drawable/btn_close" android:icon="@drawable/btn_close"
android:title="@string/bookmark_action_bar_close" android:title="@string/bookmark_action_bar_close"
app:showAsAction="always" app:showAsAction="ifRoom"
app:iconTint="@color/dark_mode_tint" /> app:iconTint="@color/dark_mode_tint" />
</group> </group>
<group <group
......
...@@ -26,7 +26,7 @@ ...@@ -26,7 +26,7 @@
android:id="@+id/close_menu_id" android:id="@+id/close_menu_id"
android:icon="@drawable/btn_close" android:icon="@drawable/btn_close"
android:title="@string/close" android:title="@string/close"
app:showAsAction="always" app:showAsAction="ifRoom"
app:iconTint="@color/dark_mode_tint" /> app:iconTint="@color/dark_mode_tint" />
</group> </group>
<group android:id="@+id/with_settings_normal_menu_group" <group android:id="@+id/with_settings_normal_menu_group"
......
...@@ -25,7 +25,7 @@ ...@@ -25,7 +25,7 @@
android:id="@+id/close_menu_id" android:id="@+id/close_menu_id"
android:icon="@drawable/btn_close" android:icon="@drawable/btn_close"
android:title="@string/close" android:title="@string/close"
app:showAsAction="always" app:showAsAction="ifRoom"
app:iconTint="@color/dark_mode_tint" /> app:iconTint="@color/dark_mode_tint" />
</group> </group>
<group <group
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment