Commit 2de6c875 authored by pfeldman@chromium.org's avatar pfeldman@chromium.org

DevTools: devtools flickers when toggling between tab w/ tools and tab w/o tools.

Follow up to https://codereview.chromium.org/12254021.
Currently, Mac has an NSView wrapper around the internal contents' native view. Internal NSView respects the bookmarks bubble and is currently updated upon setTopContentOffset. I swapped frame updates for internal and external NSViews to reduce the flickering as a short term solution. We really need to change it in a way that only one update is taking place.

Review URL: https://chromiumcodereview.appspot.com/14935015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202458 0039d316-1c4b-4281-b951-d872f2087c98
parent 654bd970
...@@ -163,11 +163,11 @@ using content::WebContents; ...@@ -163,11 +163,11 @@ using content::WebContents;
[[NSView alloc] initWithFrame:containerRect]); [[NSView alloc] initWithFrame:containerRect]);
[devToolsContainerView addSubview:devToolsView]; [devToolsContainerView addSubview:devToolsView];
[splitView_ addSubview:devToolsContainerView]; [splitView_ addSubview:devToolsContainerView];
[self updateDevToolsViewFrame];
BOOL isVertical = devToolsWindow_->dock_side() == DEVTOOLS_DOCK_SIDE_RIGHT; BOOL isVertical = devToolsWindow_->dock_side() == DEVTOOLS_DOCK_SIDE_RIGHT;
[splitView_ setVertical:isVertical]; [splitView_ setVertical:isVertical];
[self updateDevToolsSplitPosition]; [self updateDevToolsSplitPosition];
[self updateDevToolsViewFrame];
} }
- (void)hideDevToolsContainer { - (void)hideDevToolsContainer {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment