Commit 2e286a40 authored by kbr@chromium.org's avatar kbr@chromium.org

Work around about:gpucrash tab crashes caused by impl-side painting.

This is a temporary workaround. The reason for the tab crashes should
be investigated and fixed, since if it happens the context is lost
early in a tab's lifetime, this bug will be triggered.

BUG=365904,368107
TBR=bajones@chromium.org

Review URL: https://codereview.chromium.org/252123003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266819 0039d316-1c4b-4281-b951-d872f2087c98
parent f1ed1c9d
...@@ -72,7 +72,11 @@ class _ContextLostValidator(page_test.PageTest): ...@@ -72,7 +72,11 @@ class _ContextLostValidator(page_test.PageTest):
new_tab = tab.browser.tabs.New() new_tab = tab.browser.tabs.New()
# To access these debug URLs from Telemetry, they have to be # To access these debug URLs from Telemetry, they have to be
# written using the chrome:// scheme. # written using the chrome:// scheme.
new_tab.Navigate('chrome://gpucrash') # The try/except is a workaround for crbug.com/368107.
try:
new_tab.Navigate('chrome://gpucrash')
except (exceptions.TabCrashException, Exception):
print 'Tab crashed while navigating to chrome://gpucrash'
# Activate the original tab and wait for completion. # Activate the original tab and wait for completion.
tab.Activate() tab.Activate()
completed = False completed = False
...@@ -82,7 +86,11 @@ class _ContextLostValidator(page_test.PageTest): ...@@ -82,7 +86,11 @@ class _ContextLostValidator(page_test.PageTest):
completed = True completed = True
except util.TimeoutException: except util.TimeoutException:
pass pass
new_tab.Close() # The try/except is a workaround for crbug.com/368107.
try:
new_tab.Close()
except (exceptions.TabCrashException, Exception):
print 'Tab crashed while closing chrome://gpucrash'
if not completed: if not completed:
raise page_test.Failure( raise page_test.Failure(
'Test didn\'t complete (no context lost event?)') 'Test didn\'t complete (no context lost event?)')
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment