Commit 2e387cb3 authored by Nigel Tao's avatar Nigel Tao Committed by Commit Bot

Replace EntryAction with chrome.fsp.Action

The EntryAction type is (now) fictional, and no longer corresponds to
anything in chrome/common/extensions/api/file_manager_private.idl

Test: "ninja ui/file_manager:closure_compile" runs without error
Bug: 613096
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I3afc580cbcf259fac2a450f24cb7088164ee235c
Reviewed-on: https://chromium-review.googlesource.com/1107027Reviewed-by: default avatarSasha Morrissey <sashab@chromium.org>
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568759}
parent 3c19d0ea
...@@ -898,7 +898,7 @@ chrome.fileManagerPrivate.configureVolume = function(volumeId, callback) {}; ...@@ -898,7 +898,7 @@ chrome.fileManagerPrivate.configureVolume = function(volumeId, callback) {};
* Requests fetching list of actions for the specified set of entries. If not * Requests fetching list of actions for the specified set of entries. If not
* possible, then returns an error via chrome.runtime.lastError. * possible, then returns an error via chrome.runtime.lastError.
* @param {!Array<!Entry>} entries * @param {!Array<!Entry>} entries
* @param {function((!Array<!EntryAction>|undefined))} callback * @param {function((!Array<!chrome.fileSystemProvider.Action>|undefined))} callback
*/ */
chrome.fileManagerPrivate.getCustomActions = function(entries, callback) {}; chrome.fileManagerPrivate.getCustomActions = function(entries, callback) {};
...@@ -967,17 +967,3 @@ chrome.fileManagerPrivate.onDriveSyncError; ...@@ -967,17 +967,3 @@ chrome.fileManagerPrivate.onDriveSyncError;
/** @type {!ChromeEvent} */ /** @type {!ChromeEvent} */
chrome.fileManagerPrivate.onAppsUpdated; chrome.fileManagerPrivate.onAppsUpdated;
/* The declaration below (EntryAction) doesn't have any corresponding entry in
* the file_manager_private.idl file.
*
* TODO(nigeltao): delete it.
*/
/**
* @typedef {{
* id: string,
* title: (string|undefined)
* }}
*/
var EntryAction;
...@@ -20,6 +20,7 @@ js_library("closure_compile_externs") { ...@@ -20,6 +20,7 @@ js_library("closure_compile_externs") {
"$externs_path/chrome_extensions.js", "$externs_path/chrome_extensions.js",
"$externs_path/command_line_private.js", "$externs_path/command_line_private.js",
"$externs_path/file_manager_private.js", "$externs_path/file_manager_private.js",
"$externs_path/file_system_provider.js",
"$externs_path/metrics_private.js", "$externs_path/metrics_private.js",
"../../externs/audio_player_foreground.js", "../../externs/audio_player_foreground.js",
"../../externs/entry_location.js", "../../externs/entry_location.js",
......
...@@ -41,6 +41,7 @@ js_library("closure_compile_externs") { ...@@ -41,6 +41,7 @@ js_library("closure_compile_externs") {
"$externs_path/chrome_extensions.js", "$externs_path/chrome_extensions.js",
"$externs_path/command_line_private.js", "$externs_path/command_line_private.js",
"$externs_path/file_manager_private.js", "$externs_path/file_manager_private.js",
"$externs_path/file_system_provider.js",
"$externs_path/metrics_private.js", "$externs_path/metrics_private.js",
"../../../externs/background/file_browser_background.js", "../../../externs/background/file_browser_background.js",
"../../../externs/background/file_browser_background_full.js", "../../../externs/background/file_browser_background_full.js",
......
...@@ -28,6 +28,7 @@ js_library("closure_compile_externs") { ...@@ -28,6 +28,7 @@ js_library("closure_compile_externs") {
"$externs_path/chrome_extensions.js", "$externs_path/chrome_extensions.js",
"$externs_path/command_line_private.js", "$externs_path/command_line_private.js",
"$externs_path/file_manager_private.js", "$externs_path/file_manager_private.js",
"$externs_path/file_system_provider.js",
"$externs_path/metrics_private.js", "$externs_path/metrics_private.js",
"../../../externs/app_window_common.js", "../../../externs/app_window_common.js",
"../../../externs/background/file_browser_background.js", "../../../externs/background/file_browser_background.js",
......
...@@ -68,6 +68,7 @@ js_library("closure_compile_externs") { ...@@ -68,6 +68,7 @@ js_library("closure_compile_externs") {
externs_list = [ externs_list = [
"$externs_path/command_line_private.js", "$externs_path/command_line_private.js",
"$externs_path/file_manager_private.js", "$externs_path/file_manager_private.js",
"$externs_path/file_system_provider.js",
"$externs_path/metrics_private.js", "$externs_path/metrics_private.js",
"$externs_path/web_animations.js", "$externs_path/web_animations.js",
"../../../externs/app_window_common.js", "../../../externs/app_window_common.js",
......
...@@ -38,6 +38,7 @@ js_library("closure_compile_externs") { ...@@ -38,6 +38,7 @@ js_library("closure_compile_externs") {
"$externs_path/chrome_extensions.js", "$externs_path/chrome_extensions.js",
"$externs_path/command_line_private.js", "$externs_path/command_line_private.js",
"$externs_path/file_manager_private.js", "$externs_path/file_manager_private.js",
"$externs_path/file_system_provider.js",
"../../../../externs/app_window_common.js", "../../../../externs/app_window_common.js",
"../../../../externs/entry_location.js", "../../../../externs/entry_location.js",
"../../../../externs/exif_entry.js", "../../../../externs/exif_entry.js",
......
...@@ -45,6 +45,7 @@ js_library("closure_compile_externs") { ...@@ -45,6 +45,7 @@ js_library("closure_compile_externs") {
externs_list = [ externs_list = [
"$externs_path/command_line_private.js", "$externs_path/command_line_private.js",
"$externs_path/file_manager_private.js", "$externs_path/file_manager_private.js",
"$externs_path/file_system_provider.js",
"$externs_path/metrics_private.js", "$externs_path/metrics_private.js",
"$externs_path/web_animations.js", "$externs_path/web_animations.js",
"../../../../externs/app_window_common.js", "../../../../externs/app_window_common.js",
......
...@@ -29,6 +29,7 @@ js_library("closure_compile_externs") { ...@@ -29,6 +29,7 @@ js_library("closure_compile_externs") {
"$externs_path/chrome_extensions.js", "$externs_path/chrome_extensions.js",
"$externs_path/command_line_private.js", "$externs_path/command_line_private.js",
"$externs_path/file_manager_private.js", "$externs_path/file_manager_private.js",
"$externs_path/file_system_provider.js",
"$externs_path/metrics_private.js", "$externs_path/metrics_private.js",
"$externs_path/web_animations.js", "$externs_path/web_animations.js",
"../../externs/entry_location.js", "../../externs/entry_location.js",
......
...@@ -33,6 +33,7 @@ js_library("closure_compile_externs") { ...@@ -33,6 +33,7 @@ js_library("closure_compile_externs") {
"$externs_path/chrome_extensions.js", "$externs_path/chrome_extensions.js",
"$externs_path/command_line_private.js", "$externs_path/command_line_private.js",
"$externs_path/file_manager_private.js", "$externs_path/file_manager_private.js",
"$externs_path/file_system_provider.js",
"$externs_path/metrics_private.js", "$externs_path/metrics_private.js",
"$externs_path/web_animations.js", "$externs_path/web_animations.js",
"../../../externs/app_window_common.js", "../../../externs/app_window_common.js",
......
...@@ -23,6 +23,7 @@ js_library("closure_compile_externs") { ...@@ -23,6 +23,7 @@ js_library("closure_compile_externs") {
externs_list = [ externs_list = [
"$externs_path/chrome_extensions.js", "$externs_path/chrome_extensions.js",
"$externs_path/file_manager_private.js", "$externs_path/file_manager_private.js",
"$externs_path/file_system_provider.js",
"$externs_path/metrics_private.js", "$externs_path/metrics_private.js",
"//third_party/analytics/externs.js", "//third_party/analytics/externs.js",
] ]
......
...@@ -21,6 +21,7 @@ js_library("closure_compile_externs") { ...@@ -21,6 +21,7 @@ js_library("closure_compile_externs") {
"$externs_path/chrome_extensions.js", "$externs_path/chrome_extensions.js",
"$externs_path/command_line_private.js", "$externs_path/command_line_private.js",
"$externs_path/file_manager_private.js", "$externs_path/file_manager_private.js",
"$externs_path/file_system_provider.js",
"$externs_path/media_player_private.js", "$externs_path/media_player_private.js",
"$externs_path/metrics_private.js", "$externs_path/metrics_private.js",
"../../externs/chrome_cast.js", "../../externs/chrome_cast.js",
......
...@@ -20,6 +20,7 @@ js_library("closure_compile_externs") { ...@@ -20,6 +20,7 @@ js_library("closure_compile_externs") {
"$externs_path/chrome_extensions.js", "$externs_path/chrome_extensions.js",
"$externs_path/command_line_private.js", "$externs_path/command_line_private.js",
"$externs_path/file_manager_private.js", "$externs_path/file_manager_private.js",
"$externs_path/file_system_provider.js",
"$externs_path/media_player_private.js", "$externs_path/media_player_private.js",
"$externs_path/metrics_private.js", "$externs_path/metrics_private.js",
"../../../externs/app_window_common.js", "../../../externs/app_window_common.js",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment