Tighten expectations for 3 flaky animated compositing tests.

These 3 tests are flaky when run in random order or even alone. As a first step in improving them, modify the tests to get away from setTimeout and to verify that the pauseAnimationAPI is working. This is unlikely to resolve the flakiness, but it will help narrow the cause. R=chrishtr BUG=653722 Review-Url: https://codereview.chromium.org/2569063002 Cr-Commit-Position: refs/heads/master@{#438608}

Tighten expectations for 3 flaky animated compositing tests.
These 3 tests are flaky when run in random order or even alone. As a first step in improving them, modify the tests to get away from setTimeout and to verify that the pauseAnimationAPI is working. This is unlikely to resolve the flakiness, but it will help narrow the cause. R=chrishtr BUG=653722 Review-Url: https://codereview.chromium.org/2569063002 Cr-Commit-Position: refs/heads/master@{#438608}
2e4858e7 · schenney · Commit bot · e2d6faa1 · 2e4858e7 · 2e4858e7
Commit 2e4858e7 authored Dec 14, 2016 by schenney Committed by Commit bot Dec 14, 2016
11 changed files
--- a/third_party/WebKit/LayoutTests/compositing/reflections/nested-reflection-anchor-point.html
+++ b/third_party/WebKit/LayoutTests/compositing/reflections/nested-reflection-anchor-point.html
@@ -2,6 +2,7 @@
 <html>
 <head>
  <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
+  <script src="../../resources/run-after-layout-and-paint.js"></script>
  <style>
  .outer {
    width: 120px;
@@ -27,16 +28,13 @@
  }
  </style>
  <script type="text/javascript" charset="utf-8">
-    if (window.testRunner)
-      testRunner.waitUntilDone();
-
    function doTest()
    {
-      window.setTimeout(function() {
-        document.getElementById('inner').className = 'inner composited changed';
-        if (window.testRunner)
-          testRunner.notifyDone();
-      }, 0);
+      if (window.testRunner) {
+        runAfterLayoutAndPaint(function() {
+          document.getElementById('inner').className = 'inner composited changed';
+        }, true);
+      }
    }
    window.addEventListener('load', doTest, false);
  </script>

--- a/third_party/WebKit/LayoutTests/compositing/reflections/nested-reflection-animated-expected.txt
+++ b/third_party/WebKit/LayoutTests/compositing/reflections/nested-reflection-animated-expected.txt
 Animation on original and reflection should both be paused half way through, giving 45deg rotation.

 1
-PASS - "webkitTransform.0" property for "inner" element at 0.5s saw something close to: 0.76
+PASS - "webkitTransform.0" property for "inner" element at 0.5s saw something close to: 0.707107

--- a/third_party/WebKit/LayoutTests/compositing/reflections/nested-reflection-animated.html
+++ b/third_party/WebKit/LayoutTests/compositing/reflections/nested-reflection-animated.html
@@ -42,7 +42,7 @@
  <script type="text/javascript" charset="utf-8">
    const expectedValues = [
      // [time, element-id, property, expected-value, tolerance]
-      [0.5, "inner", "webkitTransform.0", 0.76, 0.1],
+      [0.5, "inner", "webkitTransform.0", 0.707107, 0.000001],
    ];
    
    var pixelTest = true;

--- a/third_party/WebKit/LayoutTests/compositing/reflections/nested-reflection-transition-expected.txt
+++ b/third_party/WebKit/LayoutTests/compositing/reflections/nested-reflection-transition-expected.txt
 1
-PASS - "-webkit-transform.1" property for "inner" element at 0.5s saw something close to: 0.76
+PASS - "-webkit-transform.1" property for "inner" element at 0.5s saw something close to: 0.707107

--- a/third_party/WebKit/LayoutTests/compositing/reflections/nested-reflection-transition.html
+++ b/third_party/WebKit/LayoutTests/compositing/reflections/nested-reflection-transition.html
@@ -39,7 +39,7 @@

    const expectedValues = [
      // [time, element-id, property, expected-value, tolerance]
-      [0.5, 'inner', '-webkit-transform.1', 0.76, 0.1],
+      [0.5, 'inner', '-webkit-transform.1', 0.707107, 0.000001],
    ];

    function setupTest()

--- a/third_party/WebKit/LayoutTests/platform/linux/compositing/reflections/nested-reflection-animated-expected.png
+++ b/third_party/WebKit/LayoutTests/platform/linux/compositing/reflections/nested-reflection-animated-expected.png
--- a/third_party/WebKit/LayoutTests/platform/linux/compositing/reflections/nested-reflection-transition-expected.png
+++ b/third_party/WebKit/LayoutTests/platform/linux/compositing/reflections/nested-reflection-transition-expected.png
--- a/third_party/WebKit/LayoutTests/platform/mac/compositing/reflections/nested-reflection-animated-expected.png
+++ b/third_party/WebKit/LayoutTests/platform/mac/compositing/reflections/nested-reflection-animated-expected.png
--- a/third_party/WebKit/LayoutTests/platform/mac/compositing/reflections/nested-reflection-transition-expected.png
+++ b/third_party/WebKit/LayoutTests/platform/mac/compositing/reflections/nested-reflection-transition-expected.png
--- a/third_party/WebKit/LayoutTests/platform/win/compositing/reflections/nested-reflection-animated-expected.png
+++ b/third_party/WebKit/LayoutTests/platform/win/compositing/reflections/nested-reflection-animated-expected.png
--- a/third_party/WebKit/LayoutTests/platform/win/compositing/reflections/nested-reflection-transition-expected.png
+++ b/third_party/WebKit/LayoutTests/platform/win/compositing/reflections/nested-reflection-transition-expected.png