Commit 2e4ef53d authored by Fredrik Söderqvist's avatar Fredrik Söderqvist Committed by Chromium LUCI CQ

Assert expected values in StyleBuilderConverter::ConvertElementReference

This converter converts "<url> | none", so add DCHECKs to that effect.

Bug: 109212
Change-Id: I35f7629a1d233ed5a6e884af6538441e5a4a8d26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587170Reviewed-by: default avatarAnders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#836635}
parent f90291df
...@@ -117,12 +117,15 @@ scoped_refptr<StyleReflection> StyleBuilderConverter::ConvertBoxReflect( ...@@ -117,12 +117,15 @@ scoped_refptr<StyleReflection> StyleBuilderConverter::ConvertBoxReflect(
scoped_refptr<StyleSVGResource> StyleBuilderConverter::ConvertElementReference( scoped_refptr<StyleSVGResource> StyleBuilderConverter::ConvertElementReference(
StyleResolverState& state, StyleResolverState& state,
const CSSValue& value) { const CSSValue& value) {
const auto* url_value = DynamicTo<cssvalue::CSSURIValue>(value); if (auto* identifier_value = DynamicTo<CSSIdentifierValue>(value)) {
if (!url_value) DCHECK_EQ(identifier_value->GetValueID(), CSSValueID::kNone);
return nullptr; return nullptr;
}
const auto& url_value = To<cssvalue::CSSURIValue>(value);
SVGResource* resource = SVGResource* resource =
state.GetElementStyleResources().GetSVGResourceFromValue(*url_value); state.GetElementStyleResources().GetSVGResourceFromValue(url_value);
return StyleSVGResource::Create(resource, url_value->ValueForSerialization()); return StyleSVGResource::Create(resource, url_value.ValueForSerialization());
} }
LengthBox StyleBuilderConverter::ConvertClip(StyleResolverState& state, LengthBox StyleBuilderConverter::ConvertClip(StyleResolverState& state,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment