[fuchsia] Create system_logger resources before calling GetAmberRepo().

GetAmberRepo() may fail with an exception, in which case it is important
both that system logs are available for diagnosis, and that the finally
clause has access to the related variables that it expects.

Bug: 1067446
Change-Id: Ieed6f957d458b360c867d68ffd104fb8b830111f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133977
Auto-Submit: Wez <wez@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756303}

build/fuchsia/run_package.py

@@ -161,18 +161,18 @@ def RunPackage(output_dir, target, package_paths, package_name,
   system_logger = (
       _AttachKernelLogReader(target) if args.system_logging else None)
   try:
-    with target.GetAmberRepo():
-      if system_logger:
-        # Spin up a thread to asynchronously dump the system log to stdout
-        # for easier diagnoses of early, pre-execution failures.
-        log_output_quit_event = multiprocessing.Event()
-        log_output_thread = threading.Thread(
-            target=
-            lambda: _DrainStreamToStdout(system_logger.stdout, log_output_quit_event)
-        )
-        log_output_thread.daemon = True
-        log_output_thread.start()
+    if system_logger:
+      # Spin up a thread to asynchronously dump the system log to stdout
+      # for easier diagnoses of early, pre-execution failures.
+      log_output_quit_event = multiprocessing.Event()
+      log_output_thread = threading.Thread(
+          target=
+          lambda: _DrainStreamToStdout(system_logger.stdout, log_output_quit_event)
+      )
+      log_output_thread.daemon = True
+      log_output_thread.start()
 
+    with target.GetAmberRepo():
       target.InstallPackage(package_paths)
 
       if system_logger: