Commit 2e681dc2 authored by Bailey Berro's avatar Bailey Berro Committed by Commit Bot

Combine navigation stops on OS Settings Manage Other People page

Previously, there were navigation stops on each of 1) a user's picture
2) a user's name and 3) a user's email address. With this change, the
picture is skipped, and the email address is read as a description of
the name, removing unneccssary tab stops


Bug: 1023643
Change-Id: Ic54430b7b6c96454eae8d1ccbe297122ae92f3f9
Fixed: 1023643
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913055
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715530}
parent 17f9e7f4
...@@ -45,13 +45,17 @@ ...@@ -45,13 +45,17 @@
<div class="user-list" scrollable> <div class="user-list" scrollable>
<template is="dom-repeat" items="[[users_]]"> <template is="dom-repeat" items="[[users_]]">
<div class="user layout horizontal center two-line"> <div class="user layout horizontal center two-line">
<img class="user-icon" src="[[getProfilePictureUrl_(item)]]"> <img class="user-icon" src="[[getProfilePictureUrl_(item)]]"
aria-hidden="true">
<div class="flex layout vertical user-info no-min-width"> <div class="flex layout vertical user-info no-min-width">
<div class="text-elide" title="[[getTooltip_(item)]]"> <div class="text-elide" title="[[getTooltip_(item)]]"
aria-describedby="user-email">
[[getUserName_(item)]] [[getUserName_(item)]]
</div> </div>
<div class="secondary text-elide" title="[[item.displayEmail]]" <div class="secondary text-elide" id="user-email"
hidden$="[[!shouldShowEmail_(item)]]"> title="[[item.displayEmail]]"
hidden$="[[!shouldShowEmail_(item)]]"
aria-hidden="true">
[[item.displayEmail]] [[item.displayEmail]]
</div> </div>
</div> </div>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment