Make //chromeos/login non public deps of //chromeos

This forces explicit dependencies for code relying on //chromeos/login.
Only code that is part of the Chrome process should have these deps.

For minor BUILD.gn changes:
TBR=rdevlin.cronin@chromium.org,hidehiko@chromium.org

Bug: 918682
Change-Id: Ic443725f1f6763e36a7214f569542822db94482c
Reviewed-on: https://chromium-review.googlesource.com/c/1394800
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619976}

chrome/browser/chromeos/BUILD.gn

@@ -95,6 +95,8 @@ source_set("chromeos") {
     "//chromeos/components/multidevice/logging",
     "//chromeos/components/proximity_auth",
     "//chromeos/components/tether",
+    "//chromeos/login/auth",
+    "//chromeos/login/login_state",
     "//chromeos/network",
     "//chromeos/services/device_sync/public/cpp",
     "//chromeos/services/machine_learning/public/cpp",

chrome/browser/extensions/BUILD.gn

@@ -956,6 +956,7 @@ jumbo_static_library("extensions") {
       "//ash",
       "//ash/public/cpp",
       "//chromeos/components/proximity_auth",
+      "//chromeos/login/login_state",
       "//chromeos/services/ime/public/mojom",
       "//chromeos/services/machine_learning/public/cpp",
       "//chromeos/services/machine_learning/public/mojom",

chrome/browser/ui/BUILD.gn

@@ -1742,6 +1742,8 @@ jumbo_split_static_library("ui") {
       "//chromeos/components/multidevice/logging",
       "//chromeos/components/proximity_auth",
       "//chromeos/components/tether",
+      "//chromeos/login/auth",
+      "//chromeos/login/login_state",
       "//chromeos/resources:resources_grit",
       "//chromeos/services/assistant/public:feature_flags",
       "//chromeos/services/assistant/public/mojom",

chromeos/BUILD.gn

@@ -33,8 +33,6 @@ component("chromeos") {
     ":tools",
     "//chromeos/cryptohome",
     "//chromeos/dbus",
-    "//chromeos/login/auth",
-    "//chromeos/login/login_state",
     "//chromeos/network",
     "//chromeos/settings",
     "//dbus",
@@ -58,6 +56,8 @@ component("chromeos") {
     "//base",
     "//base:i18n",
     "//base/third_party/dynamic_annotations",
+    "//chromeos/login/auth",
+    "//chromeos/login/login_state",
     "//components/account_id",
     "//components/device_event_log",
     "//components/policy:cloud_policy_proto_generated_compile",
@@ -246,10 +246,10 @@ source_set("test_support_source_set") {
     ":cryptohome_proto",
     ":power_manager_proto",
     "//chromeos/dbus:test_support",
-    "//chromeos/login/auth:test_support",
-    "//chromeos/login/login_state:test_support",
   ]
   deps = [
+    "//chromeos/login/auth:test_support",
+    "//chromeos/login/login_state:test_support",
     "//components/account_id",
     "//google_apis",
     "//net:test_support",

chromeos/components/tether/BUILD.gn

@@ -119,6 +119,7 @@ static_library("tether") {
     "//chromeos",
     "//chromeos/components/multidevice/logging",
     "//chromeos/components/tether/proto",
+    "//chromeos/login/login_state",
     "//chromeos/services/device_sync/public/cpp",
     "//chromeos/services/multidevice_setup/public/cpp:cpp",
     "//chromeos/services/multidevice_setup/public/mojom:mojom",
@@ -265,6 +266,7 @@ source_set("unit_tests") {
     "//chromeos/components/multidevice",
     "//chromeos/components/multidevice:test_support",
     "//chromeos/components/tether/proto",
+    "//chromeos/login/login_state",
     "//chromeos/services/device_sync:test_support",
     "//chromeos/services/device_sync/public/cpp",
     "//chromeos/services/device_sync/public/cpp:test_support",

components/arc/BUILD.gn

@@ -82,6 +82,7 @@ static_library("arc") {
     "//chromeos",
     "//chromeos:login_manager_proto",
     "//chromeos:power_manager_proto",
+    "//chromeos/login/login_state",
     "//components/account_id",
     "//components/exo",
     "//components/google/core/browser",

extensions/browser/BUILD.gn

@@ -505,6 +505,7 @@ source_set("browser_tests") {
       "//chromeos",
       "//chromeos:media_perception_proto",
       "//chromeos:power_manager_proto",
+      "//chromeos/login/login_state",
     ]
   }
 }
@@ -691,6 +692,7 @@ source_set("unit_tests") {
     deps += [
       "//chromeos:media_perception_proto",
       "//chromeos:test_support",
+      "//chromeos/login/login_state",
       "//components/feedback",
       "//extensions/shell:app_shell_lib",
     ]

extensions/browser/api/BUILD.gn

@@ -2,8 +2,8 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-import("//extensions/common/api/schema.gni")
 import("//extensions/buildflags/buildflags.gni")
+import("//extensions/common/api/schema.gni")
 import("//tools/json_schema_compiler/json_schema_api.gni")
 
 assert(enable_extensions,
@@ -144,6 +144,7 @@ source_set("api") {
     deps += [
       "//chromeos",
       "//chromeos:media_perception_proto",
+      "//chromeos/login/login_state",
       "//chromeos/services/media_perception/public/mojom",
       "//chromeos/services/media_perception/public/mojom:mojom_js_data_deps",
     ]

extensions/shell/BUILD.gn

@@ -228,6 +228,7 @@ source_set("app_shell_lib") {
     ]
     deps += [
       "//chromeos",
+      "//chromeos/login/login_state",
       "//ui/chromeos",
       "//ui/display/manager",
     ]