Commit 2e75e890 authored by Dongseong Hwang's avatar Dongseong Hwang Committed by Commit Bot

ozone: set the right GBM_BO_ flags

minigbm doesn't allow to pass no flags to gbm_bo_create(). GBM_BO_USE_TEXTURING
implies texture, so use GBM_BO_USE_TEXTURING to create texture buffer.

GBM_BO_USE_TEXTURING implies GPU_READ. GBM_BO_USE_RENDERING implies GPU_WRITE.
BufferUsage::SCANOUT needs both of them because it implies GPU_READ_WRITE.

TEST=run chrome on amd64-generic
BUG=683347

Change-Id: I7431be6f5b4a8d95e6be11d86cfbf0c14b919668
Reviewed-on: https://chromium-review.googlesource.com/549095Reviewed-by: default avatarDaniel Nicoara <dnicoara@chromium.org>
Reviewed-by: default avatarDaniele Castagna <dcastagna@chromium.org>
Reviewed-by: default avatarDavid Reveman <reveman@chromium.org>
Reviewed-by: default avatarStéphane Marchesin <marcheu@chromium.org>
Reviewed-by: default avatarDongseong Hwang <dongseong.hwang@intel.com>
Commit-Queue: Dongseong Hwang <dongseong.hwang@intel.com>
Cr-Commit-Position: refs/heads/master@{#488709}
parent ba1f8592
...@@ -117,16 +117,17 @@ void DrmThread::CreateBuffer(gfx::AcceleratedWidget widget, ...@@ -117,16 +117,17 @@ void DrmThread::CreateBuffer(gfx::AcceleratedWidget widget,
uint32_t flags = 0; uint32_t flags = 0;
switch (usage) { switch (usage) {
case gfx::BufferUsage::GPU_READ: case gfx::BufferUsage::GPU_READ:
flags = GBM_BO_USE_TEXTURING;
break; break;
case gfx::BufferUsage::SCANOUT: case gfx::BufferUsage::SCANOUT:
flags = GBM_BO_USE_SCANOUT | GBM_BO_USE_RENDERING; flags = GBM_BO_USE_RENDERING | GBM_BO_USE_SCANOUT | GBM_BO_USE_TEXTURING;
break; break;
case gfx::BufferUsage::SCANOUT_CPU_READ_WRITE: case gfx::BufferUsage::SCANOUT_CPU_READ_WRITE:
flags = GBM_BO_USE_SCANOUT | GBM_BO_USE_LINEAR; flags = GBM_BO_USE_LINEAR | GBM_BO_USE_SCANOUT | GBM_BO_USE_TEXTURING;
break; break;
case gfx::BufferUsage::GPU_READ_CPU_READ_WRITE: case gfx::BufferUsage::GPU_READ_CPU_READ_WRITE:
case gfx::BufferUsage::GPU_READ_CPU_READ_WRITE_PERSISTENT: case gfx::BufferUsage::GPU_READ_CPU_READ_WRITE_PERSISTENT:
flags = GBM_BO_USE_LINEAR; flags = GBM_BO_USE_LINEAR | GBM_BO_USE_TEXTURING;
break; break;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment