app_list::SearchResult: Duplicate() is const.

There is no reason for this method to be non-const.

TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/898273002

Cr-Commit-Position: refs/heads/master@{#315266}

ash/shell/app_list.cc

@@ -192,7 +192,7 @@ class ExampleSearchResult : public app_list::SearchResult {
   WindowTypeShelfItem::Type type() const { return type_; }
 
   // app_list::SearchResult:
-  scoped_ptr<SearchResult> Duplicate() override {
+  scoped_ptr<SearchResult> Duplicate() const override {
     return scoped_ptr<SearchResult>();
   }
 

chrome/browser/ui/app_list/search/app_result.cc

@@ -123,7 +123,7 @@ void AppResult::Open(int event_flags) {
       event_flags);
 }
 
-scoped_ptr<SearchResult> AppResult::Duplicate() {
+scoped_ptr<SearchResult> AppResult::Duplicate() const {
   scoped_ptr<SearchResult> copy(
       new AppResult(profile_, app_id_, controller_,
                     display_type() == DISPLAY_RECOMMENDATION));

chrome/browser/ui/app_list/search/app_result.h

@@ -52,7 +52,7 @@ class AppResult : public SearchResult,
 
   // SearchResult overrides:
   void Open(int event_flags) override;
-  scoped_ptr<SearchResult> Duplicate() override;
+  scoped_ptr<SearchResult> Duplicate() const override;
   ui::MenuModel* GetContextMenuModel() override;
 
  private:

chrome/browser/ui/app_list/search/omnibox_result.cc

@@ -134,7 +134,7 @@ void OmniboxResult::Open(int event_flags) {
                             ui::DispositionFromEventFlags(event_flags));
 }
 
-scoped_ptr<SearchResult> OmniboxResult::Duplicate() {
+scoped_ptr<SearchResult> OmniboxResult::Duplicate() const {
   return scoped_ptr<SearchResult>(new OmniboxResult(profile_, list_controller_,
                                                     autocomplete_controller_,
                                                     is_voice_query_, match_));

chrome/browser/ui/app_list/search/omnibox_result.h

@@ -27,7 +27,7 @@ class OmniboxResult : public SearchResult {
   // SearchResult overrides:
   void Open(int event_flags) override;
 
-  scoped_ptr<SearchResult> Duplicate() override;
+  scoped_ptr<SearchResult> Duplicate() const override;
 
  private:
   void UpdateIcon();

chrome/browser/ui/app_list/search/people/people_result.cc

@@ -117,7 +117,7 @@ void PeopleResult::InvokeAction(int action_index, int event_flags) {
   }
 }
 
-scoped_ptr<SearchResult> PeopleResult::Duplicate() {
+scoped_ptr<SearchResult> PeopleResult::Duplicate() const {
   return scoped_ptr<SearchResult>(
       new PeopleResult(profile_, controller_, person_->Duplicate().Pass()));
 }

chrome/browser/ui/app_list/search/people/people_result.h

@@ -29,7 +29,7 @@ class PeopleResult : public SearchResult {
   // SearchResult overrides:
   void Open(int event_flags) override;
   void InvokeAction(int action_index, int event_flags) override;
-  scoped_ptr<SearchResult> Duplicate() override;
+  scoped_ptr<SearchResult> Duplicate() const override;
 
  private:
   void OnIconLoaded();

chrome/browser/ui/app_list/search/search_webstore_result.cc

@@ -58,7 +58,7 @@ void SearchWebstoreResult::Open(int event_flags) {
                        ui::DispositionFromEventFlags(event_flags));
 }
 
-scoped_ptr<SearchResult> SearchWebstoreResult::Duplicate() {
+scoped_ptr<SearchResult> SearchWebstoreResult::Duplicate() const {
   return scoped_ptr<SearchResult>(
       new SearchWebstoreResult(profile_, controller_, query_));
 }

chrome/browser/ui/app_list/search/search_webstore_result.h

@@ -26,7 +26,7 @@ class SearchWebstoreResult : public SearchResult {
 
   // SearchResult overrides:
   void Open(int event_flags) override;
-  scoped_ptr<SearchResult> Duplicate() override;
+  scoped_ptr<SearchResult> Duplicate() const override;
 
  private:
   Profile* profile_;

chrome/browser/ui/app_list/search/suggestions/url_suggestion_result.cc

@@ -49,7 +49,7 @@ void URLSuggestionResult::Open(int event_flags) {
                             ui::DispositionFromEventFlags(event_flags));
 }
 
-scoped_ptr<SearchResult> URLSuggestionResult::Duplicate() {
+scoped_ptr<SearchResult> URLSuggestionResult::Duplicate() const {
   URLSuggestionResult* new_result = new URLSuggestionResult(
       profile_, list_controller_, favicon_service_, suggestions_service_,
       suggestion_);

chrome/browser/ui/app_list/search/suggestions/url_suggestion_result.h

@@ -39,7 +39,7 @@ class URLSuggestionResult : public SearchResult {
 
   // SearchResult overrides:
   void Open(int event_flags) override;
-  scoped_ptr<SearchResult> Duplicate() override;
+  scoped_ptr<SearchResult> Duplicate() const override;
 
   // Refer to SearchResult::set_relevance for documentation.
   using SearchResult::set_relevance;

chrome/browser/ui/app_list/search/webstore/webstore_result.cc

@@ -128,7 +128,7 @@ void WebstoreResult::InvokeAction(int action_index, int event_flags) {
   StartInstall(action_index == kLaunchEphemeralAppAction);
 }
 
-scoped_ptr<SearchResult> WebstoreResult::Duplicate() {
+scoped_ptr<SearchResult> WebstoreResult::Duplicate() const {
   return scoped_ptr<SearchResult>(new WebstoreResult(profile_,
                                                      app_id_,
                                                      localized_name_,

chrome/browser/ui/app_list/search/webstore/webstore_result.h

@@ -47,7 +47,7 @@ class WebstoreResult : public SearchResult,
   // SearchResult overrides:
   void Open(int event_flags) override;
   void InvokeAction(int action_index, int event_flags) override;
-  scoped_ptr<SearchResult> Duplicate() override;
+  scoped_ptr<SearchResult> Duplicate() const override;
 
  private:
   // Set the initial state and start observing both InstallObserver and

ui/app_list/search/mixer.cc

@@ -207,13 +207,13 @@ void Mixer::Publish(const SortedResults& new_results,
 
   // Add items back to |ui_results| in the order of |new_results|.
   for (size_t i = 0; i < new_results.size(); ++i) {
-    SearchResult* new_result = new_results[i].result;
+    const SearchResult& new_result = *new_results[i].result;
     IdToResultMap::const_iterator ui_result_it =
-        ui_results_map.find(new_result->id());
+        ui_results_map.find(new_result.id());
     if (ui_result_it != ui_results_map.end()) {
       // Update and use the old result if it exists.
       SearchResult* ui_result = ui_result_it->second;
-      UpdateResult(*new_result, ui_result);
+      UpdateResult(new_result, ui_result);
 
       // |ui_results| takes back ownership from |ui_results_map| here.
       ui_results->Add(ui_result);
@@ -223,7 +223,7 @@ void Mixer::Publish(const SortedResults& new_results,
       ui_results_map.erase(ui_result->id());
     } else {
       // Copy the result from |new_results| otherwise.
-      ui_results->Add(new_result->Duplicate().release());
+      ui_results->Add(new_result.Duplicate().release());
     }
   }
 

ui/app_list/search/mixer_unittest.cc

@@ -34,7 +34,7 @@ class TestSearchResult : public SearchResult {
   // SearchResult overrides:
   void Open(int event_flags) override {}
   void InvokeAction(int action_index, int event_flags) override {}
-  scoped_ptr<SearchResult> Duplicate() override {
+  scoped_ptr<SearchResult> Duplicate() const override {
     return scoped_ptr<SearchResult>(new TestSearchResult(id(), relevance()));
   }
 

ui/app_list/search_result.h

@@ -131,7 +131,7 @@ class APP_LIST_EXPORT SearchResult {
 
   // TODO(mukai): Remove this method and really simplify the ownership of
   // SearchResult. Ideally, SearchResult will be copyable.
-  virtual scoped_ptr<SearchResult> Duplicate() = 0;
+  virtual scoped_ptr<SearchResult> Duplicate() const = 0;
 
   // Opens the result.
   virtual void Open(int event_flags);

ui/app_list/test/test_search_result.cc

@@ -16,7 +16,7 @@ void TestSearchResult::SetDisplayType(SearchResult::DisplayType type) {
   set_display_type(type);
 }
 
-scoped_ptr<SearchResult> TestSearchResult::Duplicate() {
+scoped_ptr<SearchResult> TestSearchResult::Duplicate() const {
   NOTREACHED();
   return nullptr;
 }

ui/app_list/test/test_search_result.h

@@ -16,7 +16,7 @@ class TestSearchResult : public SearchResult {
   ~TestSearchResult() override;
 
   // SearchResult:
-  scoped_ptr<SearchResult> Duplicate() override;
+  scoped_ptr<SearchResult> Duplicate() const override;
 
   void SetDisplayType(SearchResult::DisplayType type);