Commit 2e9706c2 authored by tony@chromium.org's avatar tony@chromium.org

Avoid a NOT_REACHED() hit when we get an empty 404 page and

link doctor is down or disabled.

We weren't fully specifying WebURLError, which caused us to
be confused when looking up the strings for the error code.

We still don't have a nice error message for this, but at least
we don't DCHECK in debug and this will now at least cause the
local error page to say there was an http 404 error.

BUG=76457

Review URL: http://codereview.chromium.org/6995091

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88543 0039d316-1c4b-4281-b951-d872f2087c98
parent f906bfeb
...@@ -2634,6 +2634,8 @@ void RenderView::didFinishResourceLoad( ...@@ -2634,6 +2634,8 @@ void RenderView::didFinishResourceLoad(
const GURL& error_page_url = GetAlternateErrorPageURL(frame_url, HTTP_404); const GURL& error_page_url = GetAlternateErrorPageURL(frame_url, HTTP_404);
if (error_page_url.is_valid()) { if (error_page_url.is_valid()) {
WebURLError original_error; WebURLError original_error;
original_error.domain = "http";
original_error.reason = 404;
original_error.unreachableURL = frame_url; original_error.unreachableURL = frame_url;
navigation_state->set_alt_error_page_fetcher( navigation_state->set_alt_error_page_fetcher(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment