Commit 2e9c078e authored by Noel Gordon's avatar Noel Gordon Committed by Commit Bot

Make FileManager browser test consistent with other browser tests

Use public. Document the browser test classes. Order the base virtuals
to match our other browser tests.

No change in behavior, no new tests.

Bug: 833834
Change-Id: I3695fabab379d86cc6cdc38bde3c6312832c567a
Reviewed-on: https://chromium-review.googlesource.com/1023678Reviewed-by: default avatarStuart Langley <slangley@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552885}
parent 80f017b2
...@@ -18,33 +18,37 @@ ...@@ -18,33 +18,37 @@
namespace file_manager { namespace file_manager {
// Parameter of FileManagerBrowserTest. // FileManagerBrowserTest parameters: first controls IN_GUEST_MODE or not, the
// The second value is the case name of JavaScript. // second is the JS test case name.
typedef std::tuple<GuestMode, const char*> TestParameter; typedef std::tuple<GuestMode, const char*> TestParameter;
// Test fixture class for normal (not multi-profile related) tests. // Test class FileManager browser tests.
class FileManagerBrowserTest : class FileManagerBrowserTest :
public FileManagerBrowserTestBase, public FileManagerBrowserTestBase,
public ::testing::WithParamInterface<TestParameter> { public ::testing::WithParamInterface<TestParameter> {
public:
GuestMode GetGuestModeParam() const override { GuestMode GetGuestModeParam() const override {
return std::get<0>(GetParam()); return std::get<0>(GetParam());
} }
const char* GetTestManifestName() const override {
return "file_manager_test_manifest.json";
}
const char* GetTestCaseNameParam() const override { const char* GetTestCaseNameParam() const override {
return std::get<1>(GetParam()); return std::get<1>(GetParam());
} }
const char* GetTestManifestName() const override {
return "file_manager_test_manifest.json";
}
}; };
IN_PROC_BROWSER_TEST_P(FileManagerBrowserTest, Test) { IN_PROC_BROWSER_TEST_P(FileManagerBrowserTest, Test) {
StartTest(); StartTest();
} }
// Test fixture class for tests that rely on deprecated event dispatch that send // Test class for FileManager browser tests that rely on deprecated event
// tests. // dispatch that send tests.
class FileManagerBrowserTestWithLegacyEventDispatch class FileManagerBrowserTestWithLegacyEventDispatch
: public FileManagerBrowserTest { : public FileManagerBrowserTest {
public:
void SetUpCommandLine(base::CommandLine* command_line) override { void SetUpCommandLine(base::CommandLine* command_line) override {
FileManagerBrowserTest::SetUpCommandLine(command_line); FileManagerBrowserTest::SetUpCommandLine(command_line);
command_line->AppendSwitchASCII("disable-blink-features", command_line->AppendSwitchASCII("disable-blink-features",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment