vda unittest: delete GLRenderingVDAClient in correct thread
In VideoDecodeAcceleratorParamTest.TestSimpleDecode there are many ASSERT_xx while testing, which aborts test and doesn't delete GLRenderingVDAClient in GetRenderingTaskRunner. 1. For thumbnail test, in fact it doesn't need ASSERT for MD5 missing, wrong format, or comparison failure since it won't break any other things. Change to EXPECT_xx and LOG(ERROR). 2. Delete GLRenderingVDAClient in VideoDecodeAcceleratorParamTest::TearDown(). When ASSERT happens it aborts test immediately and call TearDown(), so we can make sure GLRenderingVDAClient is deleted. BUG=654677 TEST=test debug version of video_decode_accelerator_unittest on Elm 1. For thumbnail test, try to not push md5 file and the test will fail and end gracefully. Add an invalid entry in md5 and the test will pass with error messages. 2. Try to make assertion in any place inside TEST_P. Test will fail and end gracefully. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2596193005 Cr-Commit-Position: refs/heads/master@{#442835}
Showing
This diff is collapsed.
Please register or sign in to comment