Commit 2f0bee38 authored by Matt Menke's avatar Matt Menke Committed by Commit Bot

Fix bug in NetworkContext Certificate Transparency tests.

The tests were waiting for a request to receive headers, but then
assuming that the request had in fact completed receiving the entire
response, including the body.

Bug: 869551
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I2771bb0f786dd18e74423941364d51607fb8b7f8
Reviewed-on: https://chromium-review.googlesource.com/1159587Reviewed-by: default avatarReilly Grant <reillyg@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580129}
parent 2c6e31c7
...@@ -255,7 +255,7 @@ TEST(NetworkContextCertTransparencyAuditingDisabledTest, ...@@ -255,7 +255,7 @@ TEST(NetworkContextCertTransparencyAuditingDisabledTest,
0 /* options */, request, client.CreateInterfacePtr(), 0 /* options */, request, client.CreateInterfacePtr(),
net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS)); net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS));
client.RunUntilResponseReceived(); client.RunUntilComplete();
EXPECT_TRUE(client.has_received_response()); EXPECT_TRUE(client.has_received_response());
EXPECT_TRUE(client.has_received_completion()); EXPECT_TRUE(client.has_received_completion());
...@@ -390,7 +390,7 @@ TEST(NetworkContextCertTransparencyAuditingEnabledTest, ...@@ -390,7 +390,7 @@ TEST(NetworkContextCertTransparencyAuditingEnabledTest,
0 /* options */, request, client.CreateInterfacePtr(), 0 /* options */, request, client.CreateInterfacePtr(),
net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS)); net::MutableNetworkTrafficAnnotationTag(TRAFFIC_ANNOTATION_FOR_TESTS));
client.RunUntilResponseReceived(); client.RunUntilComplete();
EXPECT_TRUE(client.has_received_response()); EXPECT_TRUE(client.has_received_response());
EXPECT_TRUE(client.has_received_completion()); EXPECT_TRUE(client.has_received_completion());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment