Add some unittests to AssistantControllerImpl.

Bug: b:156675499
Change-Id: I098a339572c2e8c3c319500a23d42dc69f8b4df5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204695Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#769838}

ash/BUILD.gn

@@ -1833,6 +1833,7 @@ test("ash_unittests") {
     "app_menu/notification_menu_view_unittest.cc",
     "app_menu/notification_overflow_view_unittest.cc",
     "assistant/assistant_alarm_timer_controller_unittest.cc",
+    "assistant/assistant_controller_impl_unittest.cc",
     "assistant/assistant_interaction_controller_impl_unittest.cc",
     "assistant/assistant_notification_controller_unittest.cc",
     "assistant/assistant_screen_context_controller_impl_unittest.cc",

ash/assistant/assistant_controller_impl_unittest.cc

+// Copyright 2020 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ash/assistant/assistant_controller_impl.h"
+
+#include <map>
+#include <memory>
+#include <string>
+
+#include "ash/assistant/test/assistant_ash_test_base.h"
+#include "ash/assistant/util/deep_link_util.h"
+#include "ash/public/cpp/assistant/controller/assistant_controller_observer.h"
+#include "ash/public/cpp/test/test_new_window_delegate.h"
+#include "base/scoped_observer.h"
+#include "testing/gmock/include/gmock/gmock.h"
+
+namespace ash {
+
+namespace {
+
+// MockAssistantControllerObserver ---------------------------------------------
+
+class MockAssistantControllerObserver : public AssistantControllerObserver {
+ public:
+  MockAssistantControllerObserver() = default;
+  ~MockAssistantControllerObserver() override = default;
+
+  // AssistantControllerObserver:
+  MOCK_METHOD(void, OnAssistantControllerConstructed, (), (override));
+
+  MOCK_METHOD(void, OnAssistantControllerDestroying, (), (override));
+
+  MOCK_METHOD(void, OnAssistantReady, (), (override));
+
+  MOCK_METHOD(void,
+              OnDeepLinkReceived,
+              (assistant::util::DeepLinkType type,
+               (const std::map<std::string, std::string>& params)),
+              (override));
+
+  MOCK_METHOD(void,
+              OnOpeningUrl,
+              (const GURL& url, bool in_background, bool from_server),
+              (override));
+
+  MOCK_METHOD(void,
+              OnUrlOpened,
+              (const GURL& url, bool from_server),
+              (override));
+};
+
+// MockNewWindowDelegate -------------------------------------------------------
+
+class MockNewWindowDelegate : public testing::NiceMock<TestNewWindowDelegate> {
+ public:
+  // TestNewWindowDelegate:
+  MOCK_METHOD(void,
+              NewTabWithUrl,
+              (const GURL& url, bool from_user_interaction),
+              (override));
+};
+
+// AssistantControllerImplTest -------------------------------------------------
+
+class AssistantControllerImplTest : public AssistantAshTestBase {
+ public:
+  AssistantController* controller() { return AssistantController::Get(); }
+  MockNewWindowDelegate& new_window_delegate() { return new_window_delegate_; }
+
+ private:
+  MockNewWindowDelegate new_window_delegate_;
+};
+
+}  // namespace
+
+// Tests -----------------------------------------------------------------------
+
+// Tests that AssistantController observers are notified of deep link received.
+TEST_F(AssistantControllerImplTest, NotifiesDeepLinkReceived) {
+  testing::NiceMock<MockAssistantControllerObserver> mock;
+  ScopedObserver<AssistantController, AssistantControllerObserver> obs{&mock};
+  obs.Add(controller());
+
+  EXPECT_CALL(mock, OnDeepLinkReceived)
+      .WillOnce(
+          testing::Invoke([](assistant::util::DeepLinkType type,
+                             const std::map<std::string, std::string>& params) {
+            EXPECT_EQ(assistant::util::DeepLinkType::kQuery, type);
+            EXPECT_EQ("weather",
+                      assistant::util::GetDeepLinkParam(
+                          params, assistant::util::DeepLinkParam::kQuery)
+                          .value());
+          }));
+
+  controller()->OpenUrl(
+      assistant::util::CreateAssistantQueryDeepLink("weather"));
+}
+
+// Tests that AssistantController observers are notified of URLs opening and
+// having been opened. Note that it is important that these events be notified
+// before and after the URL is actually opened respectively.
+TEST_F(AssistantControllerImplTest, NotifiesOpeningUrlAndUrlOpened) {
+  testing::NiceMock<MockAssistantControllerObserver> mock;
+  ScopedObserver<AssistantController, AssistantControllerObserver> obs{&mock};
+  obs.Add(controller());
+
+  // Enforce ordering of events.
+  testing::InSequence sequence;
+
+  EXPECT_CALL(mock, OnOpeningUrl)
+      .WillOnce(testing::Invoke(
+          [](const GURL& url, bool in_background, bool from_server) {
+            EXPECT_EQ(GURL("https://g.co/"), url);
+            EXPECT_TRUE(in_background);
+            EXPECT_TRUE(from_server);
+          }));
+
+  EXPECT_CALL(new_window_delegate(), NewTabWithUrl)
+      .WillOnce([](const GURL& url, bool from_user_interaction) {
+        EXPECT_EQ(GURL("https://g.co/"), url);
+        EXPECT_TRUE(from_user_interaction);
+      });
+
+  EXPECT_CALL(mock, OnUrlOpened)
+      .WillOnce(testing::Invoke([](const GURL& url, bool from_server) {
+        EXPECT_EQ(GURL("https://g.co/"), url);
+        EXPECT_TRUE(from_server);
+      }));
+
+  controller()->OpenUrl(GURL("https://g.co/"), /*in_background=*/true,
+                        /*from_server=*/true);
+}
+
+}  // namespace ash