Commit 2f1e9715 authored by Gabriel Charette's avatar Gabriel Charette Committed by Commit Bot

[TaskScheduler] Alive/dead instant events instead of begin/end

This is preferable because it avoids adding trace events while the
thread is idle (for which there is no precedent).

The delta between the instant events can be used to perform the same
analysis which could be performed previously (and these will be in
Slow Reports per being in an enabled category).

R=fdoray@chromium.org

Bug: 899897
Change-Id: I40d31df9f4db3ea8959f760323b7cd8f56299ce3
Reviewed-on: https://chromium-review.googlesource.com/c/1312928Reviewed-by: default avatarFrançois Doray <fdoray@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605017}
parent af5198be
...@@ -283,8 +283,8 @@ NOINLINE void SchedulerWorker::RunBackgroundDedicatedCOMWorker() { ...@@ -283,8 +283,8 @@ NOINLINE void SchedulerWorker::RunBackgroundDedicatedCOMWorker() {
void SchedulerWorker::RunWorker() { void SchedulerWorker::RunWorker() {
DCHECK_EQ(self_, this); DCHECK_EQ(self_, this);
TRACE_EVENT_BEGIN0(TRACE_DISABLED_BY_DEFAULT("task_scheduler_diagnostics"), TRACE_EVENT_INSTANT0("task_scheduler", "SchedulerWorkerThread born",
"SchedulerWorkerThread alive"); TRACE_EVENT_SCOPE_THREAD);
TRACE_EVENT_BEGIN0("task_scheduler", "SchedulerWorkerThread active"); TRACE_EVENT_BEGIN0("task_scheduler", "SchedulerWorkerThread active");
if (scheduler_worker_observer_) if (scheduler_worker_observer_)
...@@ -358,8 +358,8 @@ void SchedulerWorker::RunWorker() { ...@@ -358,8 +358,8 @@ void SchedulerWorker::RunWorker() {
self_ = nullptr; self_ = nullptr;
TRACE_EVENT_END0("task_scheduler", "SchedulerWorkerThread active"); TRACE_EVENT_END0("task_scheduler", "SchedulerWorkerThread active");
TRACE_EVENT_END0(TRACE_DISABLED_BY_DEFAULT("task_scheduler_diagnostics"), TRACE_EVENT_INSTANT0("task_scheduler", "SchedulerWorkerThread dead",
"SchedulerWorkerThread alive"); TRACE_EVENT_SCOPE_THREAD);
} }
} // namespace internal } // namespace internal
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment