Improve robustness of SwapChainFactoryDXGI::MakeBacking

SwapChainFactoryDXGI::MakeBacking calls BindTexImage on the
GLImageDXGISwapChain before binding the GL texture as GL_TEXTURE_2D.

This causes eglBindTexImage validation to run on whatever texture
happens to be bound as GL_TEXTURE_2D, causing random failures.

To fix this problem, MakeTextureAndSetParameters was moved before
the call to BindTexImage. Now eglBindTexImage validation runs on the
correct texture.

Change-Id: I3ad60c45c4acfb1b2a2fc8e5d15964accbdf8027
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636612Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#664614}

gpu/command_buffer/service/swap_chain_factory_dxgi.cc

@@ -308,7 +308,10 @@ std::unique_ptr<SharedImageBacking> SwapChainFactoryDXGI::MakeBacking(
   }
   DCHECK(d3d11_texture);
 
-  unsigned target = GL_TEXTURE_2D;
+  const unsigned target = GL_TEXTURE_2D;
+  gl::GLApi* api = gl::g_current_gl_context;
+  const GLuint service_id = MakeTextureAndSetParameters(api, target);
+
   auto image = base::MakeRefCounted<gl::GLImageDXGISwapChain>(
       size, viz::BufferFormat(format), d3d11_texture, swap_chain);
   if (!image->BindTexImage(target)) {
@@ -316,9 +319,6 @@ std::unique_ptr<SharedImageBacking> SwapChainFactoryDXGI::MakeBacking(
     return nullptr;
   }
 
-  gl::GLApi* api = gl::g_current_gl_context;
-  GLuint service_id = MakeTextureAndSetParameters(api, target);
-
   gles2::Texture* texture = nullptr;
   scoped_refptr<gles2::TexturePassthrough> passthrough_texture;