Commit 2f45c78b authored by Joshua Berenhaus's avatar Joshua Berenhaus Committed by Commit Bot

Removing kCrashReportingEnabled clearing code as per comment

Comment in ChromeMetricsServiceClient::Initialize says to remove
cleanup code for kCrashReportingEnabled after M60.

Considering it's now M87, it should be safe to remove

Change-Id: Ic57abb7e439d9d43c154d355c4d00ac1c28f4eec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416873
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: default avatarTed Choc <tedchoc@chromium.org>
Reviewed-by: default avatarAlexei Svitkine <asvitkine@chromium.org>
Auto-Submit: Joshua Berenhaus <joshber@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#807971}
parent d4e33fa5
......@@ -942,11 +942,6 @@ void BrowserProcessImpl::RegisterPrefs(PrefRegistrySimple* registry) {
registry->RegisterBooleanPref(metrics::prefs::kMetricsReportingEnabled,
GoogleUpdateSettings::GetCollectStatsConsent());
#if defined(OS_ANDROID)
registry->RegisterBooleanPref(
prefs::kCrashReportingEnabled, false);
#endif // defined(OS_ANDROID)
}
DownloadRequestLimiter* BrowserProcessImpl::download_request_limiter() {
......
......@@ -574,13 +574,6 @@ ChromeMetricsServiceClient::GetMetricsReportingDefaultState() {
void ChromeMetricsServiceClient::Initialize() {
PrefService* local_state = g_browser_process->local_state();
// Clear deprecated metrics preference for Android.
// TODO(gayane): Cleanup this code after M60 when the pref would be cleared
// from clients.
#if defined(OS_ANDROID)
local_state->ClearPref(prefs::kCrashReportingEnabled);
#endif
metrics_service_ = std::make_unique<metrics::MetricsService>(
metrics_state_manager_, this, local_state);
......
......@@ -1629,13 +1629,6 @@ const char kProfileInfoCache[] = "profile.info_cache";
// not happen if the browser crashes, so we remove the profile on next start.
const char kProfilesDeleted[] = "profiles.profiles_deleted";
// Deprecated preference for metric / crash reporting on Android. Use
// kMetricsReportingEnabled instead.
#if defined(OS_ANDROID)
const char kCrashReportingEnabled[] =
"user_experience_metrics_crash.reporting_enabled";
#endif // defined(OS_ANDROID)
// This is the location of a list of dictionaries of plugin stability stats.
const char kStabilityPluginStats[] =
"user_experience_metrics.stability.plugin_stats2";
......
......@@ -512,12 +512,6 @@ extern const char kHasSeenWelcomePage[];
extern const char kNaviOnboardGroup[];
#endif // defined(OS_WIN)
// Deprecated preference for metric / crash reporting on Android. Use
// kMetricsReportingEnabled instead.
#if defined(OS_ANDROID)
extern const char kCrashReportingEnabled[];
#endif // defined(OS_ANDROID)
extern const char kQuietNotificationPermissionShouldShowPromo[];
extern const char kQuietNotificationPermissionPromoWasShown[];
extern const char kNotificationPermissionActions[];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment