Commit 2f66db42 authored by Rakina Zata Amni's avatar Rakina Zata Amni Committed by Commit Bot

Move functions from web_local_frame_impl_find_in_page.cc to find_in_page.cc

We are moving find-in-page related functions out of
web_local_frame_impl_find_in_page.cc to its own class
(FindInPage) for easier mojoification and so that we can add
new find-in-page related functions more easily.

In this CL, we are moving functions out of
web_local_frame_impl_find_in_page.cc. In the next CL we are going to
entirely remove the functions from the WebLocalFrame interface.

Previous CLs:
crrev.com/c/956648
crrev.com/c/1025242

Next CLs:
Remove find-in-page functions from WebLocalFrame
Introduce FindInPage mojo interface

Bug: 819919
Change-Id: Ia82b5e8f1e08701b014236039d2c6e5e45410222
Reviewed-on: https://chromium-review.googlesource.com/1027013
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: default avatarTakayoshi Kochi <kochi@chromium.org>
Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Reviewed-by: default avatarYoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553801}
parent 0561df4c
...@@ -46,8 +46,7 @@ specific_include_rules = { ...@@ -46,8 +46,7 @@ specific_include_rules = {
"+gin" "+gin"
], ],
# Allow WebLocalFrameImplFindInPage.cpp to use WebLocalFrameImpl.h "find_in_page.cc" : [
"web_local_frame_impl_find_in_page.cc" : [
"+third_party/blink/renderer/core/frame/web_local_frame_impl.h", "+third_party/blink/renderer/core/frame/web_local_frame_impl.h",
], ],
} }
...@@ -49,6 +49,8 @@ blink_core_sources("frame") { ...@@ -49,6 +49,8 @@ blink_core_sources("frame") {
"event_handler_registry.cc", "event_handler_registry.cc",
"event_handler_registry.h", "event_handler_registry.h",
"external.h", "external.h",
"find_in_page.cc",
"find_in_page.h",
"frame.cc", "frame.cc",
"frame.h", "frame.h",
"frame_client.h", "frame_client.h",
...@@ -167,7 +169,6 @@ blink_core_sources("frame") { ...@@ -167,7 +169,6 @@ blink_core_sources("frame") {
"web_frame_widget_impl.h", "web_frame_widget_impl.h",
"web_local_frame_impl.cc", "web_local_frame_impl.cc",
"web_local_frame_impl.h", "web_local_frame_impl.h",
"web_local_frame_impl_find_in_page.cc",
"web_view_frame_widget.cc", "web_view_frame_widget.cc",
"web_view_frame_widget.h", "web_view_frame_widget.h",
] ]
......
...@@ -28,13 +28,13 @@ ...@@ -28,13 +28,13 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/ */
#include "third_party/blink/renderer/core/frame/web_local_frame_impl.h" #include "third_party/blink/renderer/core/frame/find_in_page.h"
#include "third_party/blink/public/web/web_document.h" #include "third_party/blink/public/web/web_document.h"
#include "third_party/blink/public/web/web_find_options.h" #include "third_party/blink/public/web/web_find_options.h"
#include "third_party/blink/public/web/web_frame_client.h" #include "third_party/blink/public/web/web_frame_client.h"
#include "third_party/blink/renderer/core/editing/finder/text_finder.h" #include "third_party/blink/renderer/core/editing/finder/text_finder.h"
#include "third_party/blink/renderer/core/page/find_in_page.h" #include "third_party/blink/renderer/core/frame/web_local_frame_impl.h"
namespace blink { namespace blink {
......
...@@ -2,8 +2,8 @@ ...@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
#ifndef THIRD_PARTY_BLINK_RENDERER_CORE_PAGE_FIND_IN_PAGE_H_ #ifndef THIRD_PARTY_BLINK_RENDERER_CORE_FRAME_FIND_IN_PAGE_H_
#define THIRD_PARTY_BLINK_RENDERER_CORE_PAGE_FIND_IN_PAGE_H_ #define THIRD_PARTY_BLINK_RENDERER_CORE_FRAME_FIND_IN_PAGE_H_
#include "third_party/blink/public/platform/web_common.h" #include "third_party/blink/public/platform/web_common.h"
#include "third_party/blink/public/web/web_local_frame.h" #include "third_party/blink/public/web/web_local_frame.h"
......
...@@ -170,6 +170,7 @@ ...@@ -170,6 +170,7 @@
#include "third_party/blink/renderer/core/exported/web_remote_frame_impl.h" #include "third_party/blink/renderer/core/exported/web_remote_frame_impl.h"
#include "third_party/blink/renderer/core/exported/web_view_impl.h" #include "third_party/blink/renderer/core/exported/web_view_impl.h"
#include "third_party/blink/renderer/core/frame/deprecation.h" #include "third_party/blink/renderer/core/frame/deprecation.h"
#include "third_party/blink/renderer/core/frame/find_in_page.h"
#include "third_party/blink/renderer/core/frame/frame_console.h" #include "third_party/blink/renderer/core/frame/frame_console.h"
#include "third_party/blink/renderer/core/frame/local_dom_window.h" #include "third_party/blink/renderer/core/frame/local_dom_window.h"
#include "third_party/blink/renderer/core/frame/local_frame_view.h" #include "third_party/blink/renderer/core/frame/local_frame_view.h"
...@@ -210,7 +211,6 @@ ...@@ -210,7 +211,6 @@
#include "third_party/blink/renderer/core/loader/navigation_scheduler.h" #include "third_party/blink/renderer/core/loader/navigation_scheduler.h"
#include "third_party/blink/renderer/core/messaging/message_port.h" #include "third_party/blink/renderer/core/messaging/message_port.h"
#include "third_party/blink/renderer/core/page/context_menu_controller.h" #include "third_party/blink/renderer/core/page/context_menu_controller.h"
#include "third_party/blink/renderer/core/page/find_in_page.h"
#include "third_party/blink/renderer/core/page/focus_controller.h" #include "third_party/blink/renderer/core/page/focus_controller.h"
#include "third_party/blink/renderer/core/page/frame_tree.h" #include "third_party/blink/renderer/core/page/frame_tree.h"
#include "third_party/blink/renderer/core/page/page.h" #include "third_party/blink/renderer/core/page/page.h"
......
...@@ -25,7 +25,6 @@ blink_core_sources("page") { ...@@ -25,7 +25,6 @@ blink_core_sources("page") {
"drag_session.h", "drag_session.h",
"drag_state.h", "drag_state.h",
"event_with_hit_test_results.h", "event_with_hit_test_results.h",
"find_in_page.h",
"focus_changed_observer.cc", "focus_changed_observer.cc",
"focus_changed_observer.h", "focus_changed_observer.h",
"focus_controller.cc", "focus_controller.cc",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment