Commit 2f703132 authored by Irina Yatsenko's avatar Irina Yatsenko Committed by Commit Bot

Allow v8 to indicate that a full heap dump might be needed on crash.

depends on https://chromium-review.googlesource.com/c/v8/v8/+/1838927

Bug: chromium:1010312
Change-Id: I400537daf428e46180f15444d92a3dedab6aca3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838265Reviewed-by: default avatarStefan Zager <szager@chromium.org>
Commit-Queue: Irina Yatsenko <irinayat@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#703992}
parent d892ac8d
......@@ -302,6 +302,11 @@ void AddCrashKey(v8::CrashKeyId id, const std::string& value) {
bd::CrashKeySize::Size32);
bd::SetCrashKeyString(code_space_firstpage_address, value);
break;
case v8::CrashKeyId::kDumpType:
static bd::CrashKeyString* dump_type =
bd::AllocateCrashKeyString("dump-type", bd::CrashKeySize::Size32);
bd::SetCrashKeyString(dump_type, value);
break;
default:
// Doing nothing for new keys is a valid option. Having this case allows
// to introduce new CrashKeyId's without triggering a build break.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment