Commit 2f705bf4 authored by Jeremy Roman's avatar Jeremy Roman Committed by Commit Bot

Sheriffing: Disable two TwoClientWebAppsBMOSyncTest tests on all configurations.

They are flaky in several different configurations.

Bug: 1099847
Change-Id: Ic4d45a619bd72e070dbf7eb75ee3e55687341560
Tbr: jkrcal@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280221Reviewed-by: default avatarJeremy Roman <jbroman@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#784884}
parent 8dc4b88e
...@@ -182,16 +182,9 @@ IN_PROC_BROWSER_TEST_F(TwoClientWebAppsBMOSyncTest, ...@@ -182,16 +182,9 @@ IN_PROC_BROWSER_TEST_F(TwoClientWebAppsBMOSyncTest,
EXPECT_TRUE(AllProfilesHaveSameWebAppIds()); EXPECT_TRUE(AllProfilesHaveSameWebAppIds());
} }
// Flakily fails on Mac ASAN, Linux TSAN: crbug.com/1099847 // Flakily fails on multiple configurations. https://crbug.com/1099847
#if defined(THREAD_SANITIZER) || defined(ADDRESS_SANITIZER)
#define MAYBE_SyncDoubleInstallationDifferentNames \
DISABLED_SyncDoubleInstallationDifferentNames
#else
#define MAYBE_SyncDoubleInstallationDifferentNames \
SyncDoubleInstallationDifferentNames
#endif
IN_PROC_BROWSER_TEST_F(TwoClientWebAppsBMOSyncTest, IN_PROC_BROWSER_TEST_F(TwoClientWebAppsBMOSyncTest,
MAYBE_SyncDoubleInstallationDifferentNames) { DISABLED_SyncDoubleInstallationDifferentNames) {
ASSERT_TRUE(SetupSync()); ASSERT_TRUE(SetupSync());
ASSERT_TRUE(AllProfilesHaveSameWebAppIds()); ASSERT_TRUE(AllProfilesHaveSameWebAppIds());
...@@ -219,16 +212,10 @@ IN_PROC_BROWSER_TEST_F(TwoClientWebAppsBMOSyncTest, ...@@ -219,16 +212,10 @@ IN_PROC_BROWSER_TEST_F(TwoClientWebAppsBMOSyncTest,
EXPECT_EQ(GetRegistrar(GetProfile(1)).GetAppShortName(app_id), "Test name 2"); EXPECT_EQ(GetRegistrar(GetProfile(1)).GetAppShortName(app_id), "Test name 2");
} }
// Flakily fails on Mac ASAN: crbug.com/1099847 // Flakily fails on multiple configurations. https://crbug.com/1099847
#if defined(THREAD_SANITIZER) || defined(ADDRESS_SANITIZER) IN_PROC_BROWSER_TEST_F(
#define MAYBE_SyncDoubleInstallationDifferentUserDisplayMode \ TwoClientWebAppsBMOSyncTest,
DISABLED_SyncDoubleInstallationDifferentUserDisplayMode DISABLED_SyncDoubleInstallationDifferentUserDisplayMode) {
#else
#define MAYBE_SyncDoubleInstallationDifferentUserDisplayMode \
SyncDoubleInstallationDifferentUserDisplayMode
#endif
IN_PROC_BROWSER_TEST_F(TwoClientWebAppsBMOSyncTest,
MAYBE_SyncDoubleInstallationDifferentUserDisplayMode) {
ASSERT_TRUE(SetupSync()); ASSERT_TRUE(SetupSync());
ASSERT_TRUE(AllProfilesHaveSameWebAppIds()); ASSERT_TRUE(AllProfilesHaveSameWebAppIds());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment