Commit 2fa40f2c authored by nednguyen's avatar nednguyen Committed by Commit bot

[Telemetry] Make the logging message when screenshot capturing fail less verbose.

Adding the stack trace of screenshot failure will make it's harder for perf
sherrifs to diagnore issue. Switch this to log the exception object instead.

BUG=549326

Review URL: https://codereview.chromium.org/1408063008

Cr-Commit-Position: refs/heads/master@{#357012}
parent e2a17999
...@@ -136,9 +136,9 @@ class SharedPageState(story.SharedState): ...@@ -136,9 +136,9 @@ class SharedPageState(story.SharedState):
logging.warning( logging.warning(
'Either tab has crashed or browser does not support taking tab ' 'Either tab has crashed or browser does not support taking tab '
'screenshot. Skip taking screenshot on failure.') 'screenshot. Skip taking screenshot on failure.')
except Exception: except Exception as e:
exception_formatter.PrintFormattedException( logging.warning('Exception when trying to capture screenshot: %s',
msg='Error when trying to capture screenshot:') repr(e))
def DidRunStory(self, results): def DidRunStory(self, results):
if self._finder_options.profiler: if self._finder_options.profiler:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment