Commit 2fa56e67 authored by simonhatch's avatar simonhatch Committed by Commit bot

Revert of Temporarily upload minidump to private cloud storage on windows....

Revert of Temporarily upload minidump to private cloud storage on windows. (patchset #1 id:1 of https://codereview.chromium.org/899293003/)

Reason for revert:
Got a minidump, reverting.

Original issue's description:
> Temporarily upload minidump to private cloud storage on windows.
>
> Should be reverted once we have one from crashing startup.warm.blank_page perf test.
>
> BUG=433966
>
> Committed: https://crrev.com/82a66024f96d8643f42e9ad21fcf3e79e78c8804
> Cr-Commit-Position: refs/heads/master@{#314902}

TBR=sullivan@chromium.org,skyostil@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=433966

Review URL: https://codereview.chromium.org/896303003

Cr-Commit-Position: refs/heads/master@{#315033}
parent 87e95e5d
......@@ -2,7 +2,6 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
import datetime
import glob
import heapq
import logging
......@@ -18,7 +17,6 @@ from telemetry.core import exceptions
from telemetry.core import util
from telemetry.core.backends import browser_backend
from telemetry.core.backends.chrome import chrome_browser_backend
from telemetry.util import cloud_storage
from telemetry.util import path
from telemetry.util import support_binaries
......@@ -328,19 +326,6 @@ class DesktopBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):
return subprocess.check_output([stackwalk, minidump, symbols_path],
stderr=open(os.devnull, 'w'))
def _UploadMinidumpToCloudStorage(self, minidump_path):
os_name = self.browser.platform.GetOSName()
if os_name == 'win':
try:
remote_path = ('minidump-%s.dmp' % (
datetime.datetime.now().strftime('%Y-%m-%d_%H-%M-%S')))
cloud_url = cloud_storage.Insert(
cloud_storage.INTERNAL_BUCKET, remote_path, minidump_path)
print 'View minidump online at %s\n' % cloud_url
except cloud_storage.PermissionError as e:
logging.error('Cannot upload minidump to cloud storage due to'
' permission error: %s' % e.message)
def GetStackTrace(self):
most_recent_dump = self._GetMostRecentMinidump()
if not most_recent_dump:
......@@ -348,9 +333,6 @@ class DesktopBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):
self.GetStandardOutput())
logging.info('minidump found: %s' % most_recent_dump)
self._UploadMinidumpToCloudStorage(most_recent_dump)
stack = self._GetStackFromMinidump(most_recent_dump)
if not stack:
return 'Failed to symbolize minidump. Returning browser stdout:\n' + (
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment