Commit 2fb6857f authored by Andrew Grieve's avatar Andrew Grieve Committed by Commit Bot

tombstones.py, crashpad_stackwalker.py: Change devil_chromium

to pass output_directory.

Bug: 1120190
Change-Id: Ibd449d4351200a4d4c50c1d9f281d611ae9ca133
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480625
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: default avatarBen Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818018}
parent 3edc6e8d
......@@ -119,8 +119,7 @@ def main():
description='Fetches Crashpad dumps from a given device, '
'walks and symbolizes the stacks.')
parser.add_argument('--device', required=True, help='Device serial number')
parser.add_argument(
'--adb-path', required=True, help='Path to the "adb" command')
parser.add_argument('--adb-path', help='Path to the "adb" command')
parser.add_argument(
'--build-path',
required=True,
......@@ -137,7 +136,8 @@ def main():
logging.error('Missing minidump_stackwalk executable')
return 1
devil_chromium.Initialize(adb_path=args.adb_path)
devil_chromium.Initialize(output_directory=args.build_path,
adb_path=args.adb_path)
device = device_utils.DeviceUtils(args.device)
device_crashpad_path = posixpath.join(args.chrome_cache_path, 'Crashpad',
......
......@@ -251,16 +251,15 @@ def main():
help='Path to the adb binary.')
args = parser.parse_args()
devil_chromium.Initialize(adb_path=args.adb_path)
if args.output_directory:
constants.SetOutputDirectory(args.output_directory)
devil_chromium.Initialize(output_directory=constants.GetOutDirectory(),
adb_path=args.adb_path)
denylist = (device_denylist.Denylist(args.denylist_file)
if args.denylist_file else None)
if args.output_directory:
constants.SetOutputDirectory(args.output_directory)
# Do an up-front test that the output directory is known.
constants.CheckOutputDirectory()
if args.device:
devices = [device_utils.DeviceUtils(args.device)]
else:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment