Consistently apply scale factor when printing.
In https://crrev.com/560879, PrintRenderFrameHelper::PrintPagesNative() started to consider the scale factor. The Linux version of PrintPagesNative() applied it consistently to every page using GetScaleFactor(), but the Windows/Mac version of PrintPagesNative() is missing a GetScaleFactor() call for the first page. The comments for patch set 15 of the CL say PrintPagesNative() is most commonly used for printing with the system dialog, where the scale factor is always 1, so the missing GetScaleFactor() call does not matter in this case. The only time when the scale factor may be set to some other value is for headless printing. Likely nobody noticed because: - Headless printing on Win/Mac is uncommon. - Headless printing with a different scale factor is uncommon. - The combination of the two is rare. Nevertheless, the missing GetScaleFactor() should be added. Change-Id: Ic4318e3bd0a9537e0170454cbdfcb7015efad237 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705643Reviewed-by:Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#678429}
Showing
Please register or sign in to comment