Commit 2fd31766 authored by Marc Treib's avatar Marc Treib Committed by Commit Bot

Fix a DCHECK in PasswordStore::NotifyDeletionsHaveSynced

The DCHECK ensured that there are no unsynced deletions, which is only
correct if the |success| param is true.

Bug: 1086433
Change-Id: I2f8de54e33d48384b7499a9bfaf3affb968344ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260774Reviewed-by: default avatarMohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781361}
parent e53007ab
...@@ -753,7 +753,7 @@ void PasswordStore::NotifyDeletionsHaveSynced(bool success) { ...@@ -753,7 +753,7 @@ void PasswordStore::NotifyDeletionsHaveSynced(bool success) {
// telling us that it won't commit them (because Sync was turned off // telling us that it won't commit them (because Sync was turned off
// permanently). In either case, run the corresponding callbacks now (on the // permanently). In either case, run the corresponding callbacks now (on the
// main task runner). // main task runner).
DCHECK(!GetMetadataStore()->HasUnsyncedDeletions()); DCHECK(!success || !GetMetadataStore()->HasUnsyncedDeletions());
if (!deletions_have_synced_callbacks_.empty()) { if (!deletions_have_synced_callbacks_.empty()) {
base::UmaHistogramBoolean( base::UmaHistogramBoolean(
"PasswordManager.PasswordStoreDeletionsHaveSynced", success); "PasswordManager.PasswordStoreDeletionsHaveSynced", success);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment