Commit 2fd46e86 authored by Kent Tamura's avatar Kent Tamura Committed by Commit Bot

TextControl NG: Fix intrinsic minimum inline size

IsContentMinimumInlineSizeZero() was wrong. Text controls should
return true only if LogicalWidth().IsPercentOrCalc().
This change fixes 9 failing tests with LayoutNGTextArea flag.

This CL has no behavior changes. LayoutNGTextArea flag is disabled yet.

Bug: 1040826
Change-Id: I9f22de17ba8ea674240516c481558e5570a0c956
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461086Reviewed-by: default avatarKoji Ishii <kojii@chromium.org>
Reviewed-by: default avatarYoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#815109}
parent 77826976
......@@ -398,14 +398,14 @@ bool CanUseCachedIntrinsicInlineSizes(const MinMaxSizesInput& input,
}
bool IsContentMinimumInlineSizeZero(const NGBlockNode& block_node) {
if (block_node.IsTextControl())
return true;
const auto* node = block_node.GetDOMNode();
const auto* marquee_element = DynamicTo<HTMLMarqueeElement>(node);
if (marquee_element && marquee_element->IsHorizontal())
return true;
if (!block_node.Style().LogicalWidth().IsPercentOrCalc())
return false;
if (block_node.IsTextControl())
return true;
if (IsA<HTMLSelectElement>(node))
return true;
if (const auto* input_element = DynamicTo<HTMLInputElement>(node)) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment