Commit 2ff1a3de authored by Kevin Marshall's avatar Kevin Marshall Committed by Commit Bot

[cast_streaming] Add message receipt acks to CastMessagePortImpl.

Adds missing message ack invocations which blocked flow of FIDL
messages.

The issue didn't exist prior to CL 2458877,  because the FIDL/Blink
bridge that was in place discarded flow control signals.
As a result of that CL, CastMessagePortImpl now communicates
point-to-point over FIDL with no bridges in between, and therefore
the lack of acknowledgements lead to stalls in message delivery.

Test: Manually tested Cast Streaming.
Bug: 1140743
Change-Id: I05be612c110340094725f4aeb13cfc2e8e1adeaf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490552
Auto-Submit: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: default avatarFabrice de Gans-Riberi <fdegans@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819631}
parent 40222a22
...@@ -273,6 +273,11 @@ void CastMessagePortImpl::PostMessage( ...@@ -273,6 +273,11 @@ void CastMessagePortImpl::PostMessage(
<< ", namespace=" << message_namespace << ", namespace=" << message_namespace
<< ", message=" << str_message; << ", message=" << str_message;
} }
// Acknowledge the message and unblock the receipt of another.
fuchsia::web::MessagePort_PostMessage_Result result;
result.set_response(fuchsia::web::MessagePort_PostMessage_Response());
callback(std::move(result));
} }
void CastMessagePortImpl::ReceiveMessage( void CastMessagePortImpl::ReceiveMessage(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment