Commit 30029f7b authored by Wez's avatar Wez Committed by Commit Bot

Temporarily bundle all SOs from the SDK "dist" directory into packages.

We previously attempted to include only the SOs listed in the primary
executable's ELF headers as NEEDED. This causes SOs needed by other
executables in the package to be missed, as well as any libraries used
by the executable, but loaded via dlopen() rather than at load-time.

Bug: 861931
Change-Id: If72d8007ca7d18674dd28eb310a0a5aa76519516
Reviewed-on: https://chromium-review.googlesource.com/1170179Reviewed-by: default avatarKevin Marshall <kmarshall@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581998}
parent ca944e53
...@@ -179,10 +179,13 @@ def BuildManifest(root_dir, out_dir, app_name, app_filename, ...@@ -179,10 +179,13 @@ def BuildManifest(root_dir, out_dir, app_name, app_filename,
# Compute the set of dynamic libraries used by the application or its # Compute the set of dynamic libraries used by the application or its
# transitive dependencies (dist libs and components), and merge the result # transitive dependencies (dist libs and components), and merge the result
# with |expanded_files| so that they are included in the manifest. # with |expanded_files| so that they are included in the manifest.
expanded_files = expanded_files.union(
ComputeTransitiveLibDeps( # TODO(https://crbug.com/861931): Temporarily just include all |dist_libs|.
app_filename, #expanded_files = expanded_files.union(
{os.path.basename(f): f for f in expanded_files.union(dist_libs)})) # ComputeTransitiveLibDeps(
# app_filename,
# {os.path.basename(f): f for f in expanded_files.union(dist_libs)}))
expanded_files = expanded_files.union(dist_libs)
# Format and write out the manifest contents. # Format and write out the manifest contents.
app_found = False app_found = False
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment