Commit 300a9a4c authored by Kent Tamura's avatar Kent Tamura Committed by Commit Bot

Make LayoutNGTextArea flag "test" state

The feature still has one unit test failure and three web test
failures.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng_disabled
Bug: 1040826, 1137666, 1138820, 1140302, 1140307
Change-Id: I1c149d21af31a89dbed5a97e5c274c338a1bb932
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454579
Auto-Submit: Kent Tamura <tkent@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: default avatarYoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818795}
parent 0f5a8880
...@@ -28,6 +28,7 @@ ...@@ -28,6 +28,7 @@
#include "third_party/blink/renderer/modules/accessibility/ax_object.h" #include "third_party/blink/renderer/modules/accessibility/ax_object.h"
#include "third_party/blink/renderer/modules/accessibility/ax_position.h" #include "third_party/blink/renderer/modules/accessibility/ax_position.h"
#include "third_party/blink/renderer/modules/accessibility/testing/accessibility_selection_test.h" #include "third_party/blink/renderer/modules/accessibility/testing/accessibility_selection_test.h"
#include "third_party/blink/renderer/platform/testing/runtime_enabled_features_test_helpers.h"
#include "third_party/blink/renderer/platform/wtf/text/wtf_string.h" #include "third_party/blink/renderer/platform/wtf/text/wtf_string.h"
namespace blink { namespace blink {
...@@ -760,6 +761,9 @@ TEST_F(AccessibilitySelectionTest, FromCurrentSelectionInTextareaWithAffinity) { ...@@ -760,6 +761,9 @@ TEST_F(AccessibilitySelectionTest, FromCurrentSelectionInTextareaWithAffinity) {
TEST_F(AccessibilitySelectionTest, TEST_F(AccessibilitySelectionTest,
FromCurrentSelectionInTextareaWithCollapsedSelectionAndAffinity) { FromCurrentSelectionInTextareaWithCollapsedSelectionAndAffinity) {
// TODO(crbug.com/1140302): This test fails with LayoutNGTextArea.
ScopedLayoutNGTextAreaForTest scope(false);
SetBodyInnerHTML(R"HTML( SetBodyInnerHTML(R"HTML(
<textarea id="textarea" <textarea id="textarea"
rows="2" cols="15" rows="2" cols="15"
......
...@@ -1040,6 +1040,7 @@ ...@@ -1040,6 +1040,7 @@
{ {
name: "LayoutNGTextArea", name: "LayoutNGTextArea",
depends_on: ["EditingNG"], depends_on: ["EditingNG"],
status: "test",
}, },
{ {
name: "LayoutNGTextField", name: "LayoutNGTextField",
......
...@@ -1196,6 +1196,11 @@ crbug.com/1121942 virtual/layout_ng_printing/printing/fixed-positioned-child-sho ...@@ -1196,6 +1196,11 @@ crbug.com/1121942 virtual/layout_ng_printing/printing/fixed-positioned-child-sho
crbug.com/1121942 virtual/layout_ng_printing/printing/frameset.html [ Failure ] crbug.com/1121942 virtual/layout_ng_printing/printing/frameset.html [ Failure ]
crbug.com/1121942 virtual/layout_ng_printing/printing/webgl-oversized-printing.html [ Skip ] crbug.com/1121942 virtual/layout_ng_printing/printing/webgl-oversized-printing.html [ Skip ]
### Textarea NG
crbug.com/1140307 accessibility/inline-text-textarea.html [ Failure ]
crbug.com/1137666 editing/caret/caret-direction-auto.html [ Failure ]
crbug.com/1138820 fast/forms/text/input-appearance-scroll-size-mocked.html [ Failure ]
# ====== LayoutNG-only failures until here ====== # ====== LayoutNG-only failures until here ======
# ====== MathMLCore-only tests from here ====== # ====== MathMLCore-only tests from here ======
......
...@@ -8,19 +8,19 @@ ...@@ -8,19 +8,19 @@
"backgroundColor": "#FFFFFF" "backgroundColor": "#FFFFFF"
}, },
{ {
"name": "LayoutTextControl TEXTAREA", "name": "LayoutNGTextControlMultiLine TEXTAREA",
"position": [1, 1], "position": [1, 1],
"bounds": [189, 124], "bounds": [189, 124],
"drawsContent": false, "drawsContent": false,
"transform": 1 "transform": 1
}, },
{ {
"name": "Scroll corner of LayoutTextControl TEXTAREA", "name": "Scroll corner of LayoutNGTextControlMultiLine TEXTAREA",
"position": [193, 18], "position": [193, 18],
"bounds": [261, 126] "bounds": [261, 126]
}, },
{ {
"name": "LayoutTextControl TEXTAREA", "name": "LayoutNGTextControlMultiLine TEXTAREA",
"position": [1, 1], "position": [1, 1],
"bounds": [189, 328], "bounds": [189, 328],
"backgroundColor": "#CCCCCC", "backgroundColor": "#CCCCCC",
...@@ -33,20 +33,20 @@ ...@@ -33,20 +33,20 @@
"transform": 1 "transform": 1
}, },
{ {
"name": "LayoutTextControl TEXTAREA", "name": "LayoutNGTextControlMultiLine TEXTAREA",
"position": [1, 1], "position": [1, 1],
"bounds": [189, 124], "bounds": [189, 124],
"drawsContent": false, "drawsContent": false,
"transform": 3 "transform": 3
}, },
{ {
"name": "Scroll corner of LayoutTextControl TEXTAREA", "name": "Scroll corner of LayoutNGTextControlMultiLine TEXTAREA",
"position": [175, 95], "position": [175, 95],
"bounds": [30, 30], "bounds": [30, 30],
"transform": 3 "transform": 3
}, },
{ {
"name": "LayoutTextControl TEXTAREA", "name": "LayoutNGTextControlMultiLine TEXTAREA",
"position": [1, 1], "position": [1, 1],
"bounds": [189, 328], "bounds": [189, 328],
"backgroundColor": "#CCCCCC", "backgroundColor": "#CCCCCC",
......
{
"layers": [
{
"name": "Scrolling Contents Layer",
"bounds": [800, 600],
"contentsOpaque": true,
"backgroundColor": "#FFFFFF"
},
{
"name": "LayoutTextControl TEXTAREA",
"bounds": [206, 126],
"transform": 1
},
{
"name": "ContentsLayer for Vertical Scrollbar Layer",
"position": [190, 1],
"bounds": [15, 109],
"transform": 1
},
{
"name": "Scroll Corner Layer",
"position": [190, 110],
"bounds": [15, 15],
"transform": 1
},
{
"name": "Scrolling Contents Layer",
"position": [1, 1],
"bounds": [189, 328],
"contentsOpaque": true,
"backgroundColor": "#CCCCCC",
"transform": 2
},
{
"name": "LayoutTextControl TEXTAREA",
"bounds": [206, 126],
"transform": 3
},
{
"name": "ContentsLayer for Vertical Scrollbar Layer",
"position": [190, 1],
"bounds": [15, 109],
"transform": 3
},
{
"name": "Scroll Corner Layer",
"position": [190, 110],
"bounds": [15, 15],
"transform": 3
},
{
"name": "Scrolling Contents Layer",
"position": [1, 1],
"bounds": [189, 328],
"contentsOpaque": true,
"backgroundColor": "#CCCCCC",
"transform": 4
}
],
"transforms": [
{
"id": 1,
"transform": [
[1, 0, 0, 0],
[0, 1, 0, 0],
[0, 0, 1, 0],
[18, 18, 0, 1]
]
},
{
"id": 2,
"parent": 1,
"transform": [
[1, 0, 0, 0],
[0, 1, 0, 0],
[0, 0, 1, 0],
[0, -50, 0, 1]
]
},
{
"id": 3,
"transform": [
[1, 0, 0, 0],
[0, 1, 0, 0],
[0, 0, 1, 0],
[248, 18, 0, 1]
]
},
{
"id": 4,
"parent": 3,
"transform": [
[1, 0, 0, 0],
[0, 1, 0, 0],
[0, 0, 1, 0],
[0, -50, 0, 1]
]
}
]
}
...@@ -8,7 +8,7 @@ ...@@ -8,7 +8,7 @@
"backgroundColor": "#FFFFFF" "backgroundColor": "#FFFFFF"
}, },
{ {
"name": "LayoutTextControl TEXTAREA", "name": "LayoutNGTextControlMultiLine TEXTAREA",
"bounds": [309, 189], "bounds": [309, 189],
"transform": 1 "transform": 1
}, },
...@@ -33,7 +33,7 @@ ...@@ -33,7 +33,7 @@
"transform": 1 "transform": 1
}, },
{ {
"name": "LayoutTextControl TEXTAREA", "name": "LayoutNGTextControlMultiLine TEXTAREA",
"bounds": [309, 189], "bounds": [309, 189],
"transform": 3 "transform": 3
}, },
......
...@@ -8,7 +8,7 @@ ...@@ -8,7 +8,7 @@
"backgroundColor": "#FFFFFF" "backgroundColor": "#FFFFFF"
}, },
{ {
"name": "LayoutTextControl TEXTAREA", "name": "LayoutNGTextControlMultiLine TEXTAREA",
"bounds": [206, 126], "bounds": [206, 126],
"transform": 1 "transform": 1
}, },
...@@ -33,7 +33,7 @@ ...@@ -33,7 +33,7 @@
"transform": 2 "transform": 2
}, },
{ {
"name": "LayoutTextControl TEXTAREA", "name": "LayoutNGTextControlMultiLine TEXTAREA",
"bounds": [206, 126], "bounds": [206, 126],
"transform": 3 "transform": 3
}, },
......
autowrap text area with dir=rtl.
nowrap text area with dir=rtl.
autowrap text area with dir=ltr.
vertical text.
FAIL test id: textarea_rtl_no_wrap (text width: 107 != caretRange: 106), which means moving caret in the text, caret might be invisible or overlap with element.
PASS successfullyParsed is true
TEST COMPLETE
...@@ -10,7 +10,7 @@ ...@@ -10,7 +10,7 @@
] ]
}, },
{ {
"name": "LayoutTextControl TEXTAREA id='editor'", "name": "LayoutNGTextControlMultiLine TEXTAREA id='editor'",
"position": [-2, -2], "position": [-2, -2],
"bounds": [185, 40], "bounds": [185, 40],
"backgroundColor": "#FFFFFF", "backgroundColor": "#FFFFFF",
......
...@@ -8,7 +8,7 @@ ...@@ -8,7 +8,7 @@
"backgroundColor": "#FFFFFF" "backgroundColor": "#FFFFFF"
}, },
{ {
"name": "LayoutTextControl TEXTAREA", "name": "LayoutNGTextControlMultiLine TEXTAREA",
"bounds": [206, 126], "bounds": [206, 126],
"transform": 1 "transform": 1
}, },
...@@ -33,7 +33,7 @@ ...@@ -33,7 +33,7 @@
"transform": 2 "transform": 2
}, },
{ {
"name": "LayoutTextControl TEXTAREA", "name": "LayoutNGTextControlMultiLine TEXTAREA",
"bounds": [206, 126], "bounds": [206, 126],
"transform": 3 "transform": 3
}, },
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment