Commit 301c89e2 authored by Quinten Yearsley's avatar Quinten Yearsley Committed by Commit Bot

Remove "Skipped" file and Port.skips_perf_test

I believe this might be dead code; I'm not sure if
the layout test runner is used to run any Blink
performance tests.

The last related change was last year:
https://codereview.chromium.org/2734823006

Before that, all changes seem to be from about 5 years ago.

Change-Id: Ib1a23055391112c83b97e000707f0b2f333040e5
Reviewed-on: https://chromium-review.googlesource.com/966484
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: default avatarKent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545710}
parent 474b839d
# Micro benchmarks not worth running at the moment.
DOM/TraverseChildNodes.html
# Not enabled by default on some ports
Mutation
# Unstable SVG page loading tests
SVG/Samurai.html
# Takes too long to load
SVG/SierpinskiCarpet.html
SVG/France.html
SVG/FrancoBolloGnomeEzechi.html
SVG/GearFlowers.html
SVG/HereGear.html
# Takes 22s on MacBookPro
SVG/MtSaintHelens.html
# Do not conform to WebKit or Chromium perf test styles
SunSpider
XSSAuditor
# https://bugs.webkit.org/show_bug.cgi?id=98708
Layout/subtree-detaching.html
# We have pure JS tests separately outside Dromaeo.
Dromaeo
# Bug 77024 - Web Inspector: tests in PerformanceTests/inspector/ are timing out
inspector
Canvas/drawimage.html
# crbug.com/727919, crbug.com/736374
Canvas/getImageDataColorManaged.html
# Redundant with chromium's page cyclers.
Replay
# Requires manual intervention.
Bindings/event-target-wrapper.html
# Microbenchmark that we aren't interested in monitoring.
Bindings/gc-forest.html
Bindings/gc-mini-tree.html
Bindings/gc-tree.html
Bindings/named-property-enumerator.html
# Times out on Android. crbug.com/384857
Animation/overlay-background-color-transitions.html
# Assumes window.eventSender is always supported; it only is for "content-shell" performance runs.
DOM/click_webkit_user_select_none.html
Editing/mouse-move-with-hidden-elements.html
\ No newline at end of file
......@@ -1090,34 +1090,6 @@ class Port(object):
def path_to_never_fix_tests_file(self):
return self._filesystem.join(self.layout_tests_dir(), 'NeverFixTests')
def _expectations_from_skipped_files(self, skipped_file_paths):
# TODO(qyearsley): Remove this if there are no more "Skipped" files.
tests_to_skip = []
for search_path in skipped_file_paths:
filename = self._filesystem.join(self._absolute_baseline_path(search_path), 'Skipped')
if not self._filesystem.exists(filename):
_log.debug('Skipped does not exist: %s', filename)
continue
_log.debug('Using Skipped file: %s', filename)
tests_to_skip.extend(self._tests_from_file(filename))
return tests_to_skip
@memoized
def skipped_perf_tests(self):
tests = self._expectations_from_skipped_files([self._perf_tests_dir()])
# Best to normalize directory names to not include the trailing slash.
# TODO(qyearsley): Explain why removing trailing slashes is needed here.
return sorted(test.rstrip('/') for test in tests)
def skips_perf_test(self, test_name):
for test_or_category in self.skipped_perf_tests():
if test_or_category == test_name:
return True
category = self._filesystem.join(self._perf_tests_dir(), test_or_category)
if self._filesystem.isdir(category) and test_name.startswith(test_or_category):
return True
return False
def name(self):
"""Returns a name that uniquely identifies this particular type of port.
......
......@@ -87,23 +87,6 @@ class PortTest(unittest.TestCase):
self.assertIn('canvas', dirs)
self.assertIn('css2.1', dirs)
def test_skipped_perf_tests(self):
port = self.make_port()
def add_text_file(dirname, filename, content='some content'):
dirname = port.host.filesystem.join(
PathFinder(port.host.filesystem).perf_tests_dir(), dirname)
port.host.filesystem.maybe_make_directory(dirname)
port.host.filesystem.write_text_file(port.host.filesystem.join(dirname, filename), content)
add_text_file('inspector', 'test1.html')
add_text_file('inspector', 'unsupported_test1.html')
add_text_file('inspector', 'test2.html')
add_text_file('inspector/resources', 'resource_file.html')
add_text_file('unsupported', 'unsupported_test2.html')
add_text_file('', 'Skipped', '\n'.join(['Layout', '', 'SunSpider', 'Supported/some-test.html']))
self.assertEqual(port.skipped_perf_tests(), ['Layout', 'SunSpider', 'Supported/some-test.html'])
def test_get_option__set(self):
options, _ = optparse.OptionParser().parse_args([])
options.foo = 'bar'
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment