Commit 303b9634 authored by Fredrik Söderqvist's avatar Fredrik Söderqvist Committed by Commit Bot

Drop unused argument to SVGShapePainter::PaintMarkers

The |bounding_box| argument isn't actually used, so drop it.
Also turn the check at the beginning of StrokeShape() into a DCHECK
since the (only) caller already checks it.

Change-Id: Ib5ff5d462c440a55361f9051e91e528ac3b82a5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124373Reviewed-by: default avatarStephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#754002}
parent bb73db57
......@@ -4,7 +4,6 @@
#include "third_party/blink/renderer/core/paint/svg_shape_painter.h"
#include "base/optional.h"
#include "third_party/blink/renderer/core/layout/svg/layout_svg_resource_marker.h"
#include "third_party/blink/renderer/core/layout/svg/layout_svg_shape.h"
#include "third_party/blink/renderer/core/layout/svg/svg_layout_support.h"
......@@ -125,8 +124,7 @@ void SVGShapePainter::Paint(const PaintInfo& paint_info) {
}
break;
case PT_MARKERS:
PaintMarkers(paint_state.GetPaintInfo(),
layout_svg_shape_.VisualRectInLocalSVGCoordinates());
PaintMarkers(paint_state.GetPaintInfo());
break;
default:
NOTREACHED();
......@@ -178,8 +176,7 @@ void SVGShapePainter::FillShape(GraphicsContext& context,
void SVGShapePainter::StrokeShape(GraphicsContext& context,
const PaintFlags& flags) {
if (!layout_svg_shape_.StyleRef().SvgStyle().HasVisibleStroke())
return;
DCHECK(layout_svg_shape_.StyleRef().SvgStyle().HasVisibleStroke());
switch (layout_svg_shape_.GeometryCodePath()) {
case kRectGeometryFastPath:
......@@ -200,8 +197,7 @@ void SVGShapePainter::StrokeShape(GraphicsContext& context,
}
}
void SVGShapePainter::PaintMarkers(const PaintInfo& paint_info,
const FloatRect& bounding_box) {
void SVGShapePainter::PaintMarkers(const PaintInfo& paint_info) {
const Vector<MarkerPosition>* marker_positions =
layout_svg_shape_.MarkerPositions();
if (!marker_positions || marker_positions->IsEmpty())
......
......@@ -11,7 +11,6 @@
namespace blink {
class FloatRect;
class GraphicsContext;
class LayoutSVGResourceMarker;
class LayoutSVGShape;
......@@ -31,7 +30,7 @@ class SVGShapePainter {
void FillShape(GraphicsContext&, const PaintFlags&, SkPathFillType);
void StrokeShape(GraphicsContext&, const PaintFlags&);
void PaintMarkers(const PaintInfo&, const FloatRect& bounding_box);
void PaintMarkers(const PaintInfo&);
void PaintMarker(const PaintInfo&,
LayoutSVGResourceMarker&,
const MarkerPosition&,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment