Commit 3059e6ea authored by dgozman's avatar dgozman Committed by Commit bot

[DevTools] Add implementation for Tracing.start with optional parameters.

BUG=405566
TBR=pfeldman

Review URL: https://codereview.chromium.org/663373002

Cr-Commit-Position: refs/heads/master@{#300477}
parent 5dd5ff67
...@@ -20,12 +20,6 @@ void TracingHandler::SetClient(scoped_ptr<Client> client) { ...@@ -20,12 +20,6 @@ void TracingHandler::SetClient(scoped_ptr<Client> client) {
client_.swap(client); client_.swap(client);
} }
Response TracingHandler::Start(const std::string& categories,
const std::string& options,
const double* buffer_usage_reporting_interval) {
return Response::FallThrough();
}
scoped_refptr<DevToolsProtocol::Response> TracingHandler::Start( scoped_refptr<DevToolsProtocol::Response> TracingHandler::Start(
const std::string& categories, const std::string& categories,
const std::string& options, const std::string& options,
...@@ -34,8 +28,12 @@ scoped_refptr<DevToolsProtocol::Response> TracingHandler::Start( ...@@ -34,8 +28,12 @@ scoped_refptr<DevToolsProtocol::Response> TracingHandler::Start(
return NULL; return NULL;
} }
Response TracingHandler::End() { scoped_refptr<DevToolsProtocol::Response> TracingHandler::Start(
return Response::FallThrough(); const std::string* categories,
const std::string* options,
const double* buffer_usage_reporting_interval,
scoped_refptr<DevToolsProtocol::Command> command) {
return NULL;
} }
scoped_refptr<DevToolsProtocol::Response> TracingHandler::End( scoped_refptr<DevToolsProtocol::Response> TracingHandler::End(
......
...@@ -20,18 +20,17 @@ class TracingHandler { ...@@ -20,18 +20,17 @@ class TracingHandler {
void SetClient(scoped_ptr<Client> client); void SetClient(scoped_ptr<Client> client);
// TODO(dgozman): remove sync version after migration.
Response Start(const std::string& categories,
const std::string& options,
const double* buffer_usage_reporting_interval);
scoped_refptr<DevToolsProtocol::Response> Start( scoped_refptr<DevToolsProtocol::Response> Start(
const std::string& categories, const std::string& categories,
const std::string& options, const std::string& options,
const double* buffer_usage_reporting_interval, const double* buffer_usage_reporting_interval,
scoped_refptr<DevToolsProtocol::Command> command); scoped_refptr<DevToolsProtocol::Command> command);
scoped_refptr<DevToolsProtocol::Response> Start(
const std::string* categories,
const std::string* options,
const double* buffer_usage_reporting_interval,
scoped_refptr<DevToolsProtocol::Command> command);
// TODO(dgozman): remove sync version after migration.
Response End();
scoped_refptr<DevToolsProtocol::Response> End( scoped_refptr<DevToolsProtocol::Response> End(
scoped_refptr<DevToolsProtocol::Command> command); scoped_refptr<DevToolsProtocol::Command> command);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment