Commit 3071ee7b authored by Yuri Wiitala's avatar Yuri Wiitala Committed by Commit Bot

Disable SnooperNodeTest.HandlesMissingInput for debug builds.

Unexpectedly, the test seems to randomly time out on Win dbg bots only.
Disable the test for debug builds, with a TODO to root-cause/revisit to
fix and re-enable.

TBR=olka@chromium.org

Bug: 842428
Change-Id: I8524c31247f452675e6c91d4ac5c3fc471a9525e
Reviewed-on: https://chromium-review.googlesource.com/1059858Reviewed-by: default avatarYuri Wiitala <miu@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558880}
parent b272fdaf
...@@ -202,6 +202,8 @@ class SnooperNodeTest : public testing::TestWithParam<InputAndOutputParams> { ...@@ -202,6 +202,8 @@ class SnooperNodeTest : public testing::TestWithParam<InputAndOutputParams> {
// Performance of this test on debug builds is abysmal. So, only run it on // Performance of this test on debug builds is abysmal. So, only run it on
// optimized builds. // optimized builds.
// TODO(crbug.com/842428): Analyze why only Windows debug test runs have this
// problem and re-enable test.
#ifdef NDEBUG #ifdef NDEBUG
#define MAYBE_ContinuousAudioFlowAdaptsToSkew ContinuousAudioFlowAdaptsToSkew #define MAYBE_ContinuousAudioFlowAdaptsToSkew ContinuousAudioFlowAdaptsToSkew
#else #else
...@@ -268,7 +270,16 @@ TEST_P(SnooperNodeTest, MAYBE_ContinuousAudioFlowAdaptsToSkew) { ...@@ -268,7 +270,16 @@ TEST_P(SnooperNodeTest, MAYBE_ContinuousAudioFlowAdaptsToSkew) {
} }
} }
TEST_P(SnooperNodeTest, HandlesMissingInput) { // Performance of this test on debug builds is abysmal. So, only run it on
// optimized builds.
// TODO(crbug.com/842428): Analyze why only Windows debug test runs have this
// problem and re-enable test.
#ifdef NDEBUG
#define MAYBE_HandlesMissingInput HandlesMissingInput
#else
#define MAYBE_HandlesMissingInput DISABLED_HandlesMissingInput
#endif
TEST_P(SnooperNodeTest, MAYBE_HandlesMissingInput) {
// Compute drops to occur once per second for 1/4 second duration. Each drop // Compute drops to occur once per second for 1/4 second duration. Each drop
// position must be aligned to input_params().frames_per_buffer() for the // position must be aligned to input_params().frames_per_buffer() for the
// heuristics in ScheduleInputTasks() to process these drop positions // heuristics in ScheduleInputTasks() to process these drop positions
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment