Commit 307c07bf authored by Christos Froussios's avatar Christos Froussios Committed by Commit Bot

Reland "[Password Manager] Cleanup feature: Migrate Linux to LoginDB"

This reverts commit 341d33c3.

Reason for reland: The preceding CL was also relanded.

Original change's description:
> Revert "[Password Manager] Cleanup feature: Migrate Linux to LoginDB"
> 
> This reverts commit 3a84c395.
> 
> Reason for revert: https://chromium-review.googlesource.com/c/chromium/src/+/1713560 didn't stick, see https://bugs.chromium.org/p/chromium/issues/detail?id=988010
> 
> Original change's description:
> > [Password Manager] Cleanup feature: Migrate Linux to LoginDB
> > 
> > The migration has been completed and the feature is no longer used.
> > 
> > Bug: 950269
> > Change-Id: I91f79f33ccda95e75d2b6156ade5d44f2e27c0ae
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719008
> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
> > Commit-Queue: Christos Froussios <cfroussios@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#681244}
> 
> TBR=vasilii@chromium.org,cfroussios@chromium.org
> 
> Change-Id: Ic0733620d3ebca563f5fa0be9f60742770eacd45
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 950269
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721290
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Commit-Queue: John Budorick <jbudorick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#681347}

TBR=vasilii@chromium.org,cfroussios@chromium.org,jbudorick@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 950269
Change-Id: Ifb49e8c9a6feeeaaa6e097296dda46540df66f30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724527Reviewed-by: default avatarChristos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682202}
parent 3e51c980
......@@ -2237,10 +2237,6 @@ const FeatureEntry kFeatureEntries[] = {
#endif // BUILDFLAG(ENABLE_ANDROID_NIGHT_MODE)
#endif // OS_ANDROID
#if defined(OS_LINUX) && !defined(OS_CHROMEOS)
{"passwords-migrate-linux-to-login-db",
flag_descriptions::kPasswordsMigrateLinuxToLoginDBName,
flag_descriptions::kPasswordsMigrateLinuxToLoginDBDescription, kOsLinux,
FEATURE_VALUE_TYPE(password_manager::features::kMigrateLinuxToLoginDB)},
{"enable-dbus-and-x11-status-icons",
flag_descriptions::kEnableDbusAndX11StatusIconsName,
flag_descriptions::kEnableDbusAndX11StatusIconsDescription, kOsLinux,
......
......@@ -1538,12 +1538,6 @@ const char kPasswordImportName[] = "Password import";
const char kPasswordImportDescription[] =
"Import functionality in password settings.";
const char kPasswordsMigrateLinuxToLoginDBName[] =
"Migrate passwords to \"Login Data\"";
const char kPasswordsMigrateLinuxToLoginDBDescription[] =
"Performs a one-off irreversible migration of passwords from the "
"gnome-keyring or kwallet into the profile directory.";
const char kPeriodicBackgroundSyncName[] = "Periodic Background Sync";
const char kPeriodicBackgroundSyncDescription[] =
"If enabled, web apps can periodically sync content in the background.";
......
......@@ -921,9 +921,6 @@ extern const char kPassiveDocumentWheelEventListenersDescription[];
extern const char kPasswordImportName[];
extern const char kPasswordImportDescription[];
extern const char kPasswordsMigrateLinuxToLoginDBName[];
extern const char kPasswordsMigrateLinuxToLoginDBDescription[];
extern const char kPeriodicBackgroundSyncName[];
extern const char kPeriodicBackgroundSyncDescription[];
......
......@@ -48,11 +48,6 @@ const base::Feature kLeakDetection = {"PasswordLeakDetection",
const base::Feature kManualPasswordGenerationAndroid{
"ManualPasswordGenerationAndroid", base::FEATURE_DISABLED_BY_DEFAULT};
// Performs a one-off migration (with retries) from a native backend into
// logindb. Passwords are served from the new location.
const base::Feature kMigrateLinuxToLoginDB = {"migrate-linux-to-logindb",
base::FEATURE_ENABLED_BY_DEFAULT};
// Enables new password form parsing mechanism for filling passwords, details in
// https://goo.gl/QodPH1
const base::Feature kNewPasswordFormParsing = {
......
......@@ -25,7 +25,6 @@ extern const base::Feature kGenerationNoOverwrites;
extern const base::Feature kGooglePasswordManager;
extern const base::Feature kLeakDetection;
extern const base::Feature kManualPasswordGenerationAndroid;
extern const base::Feature kMigrateLinuxToLoginDB;
extern const base::Feature kNewPasswordFormParsing;
extern const base::Feature kNewPasswordFormParsingForSaving;
extern const base::Feature kOnlyNewParser;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment