Commit 307cf166 authored by Bruce Dawson's avatar Bruce Dawson Committed by Commit Bot

Disable headless crash reporter on Windows

The headless_browsertests try to startup the crashpad-handler process
but they don't do it properly. This causes some inappropriate sandbox
code to be run, triggering a CHECK, and it means that the crashpad
process is never actually set up correctly. This has been broken as far
back as I could tell (back to April 2020 when the CHECK was added).
This incorrect setup then leads to communications errors shown with
these error messages on every test:

ERROR:registration_protocol_win.cc(130)] TransactNamedPipe:
    The pipe has been ended. (0x6D)
ERROR:registration_protocol_win.cc(102)] CreateFile:
    The system cannot find the file specified. (0x2)

It is unknown whether this fails on other platforms so for now I am just
disabling it on Windows where I know it does not work.

Bug: 1147063
Change-Id: I1d02d00de6a5af3ccc73c3db213a822eeea1c2ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543683Reviewed-by: default avatarAndrey Kosyakov <caseq@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829005}
parent 10c3d825
...@@ -369,9 +369,12 @@ void HeadlessContentMainDelegate::PreSandboxStartup() { ...@@ -369,9 +369,12 @@ void HeadlessContentMainDelegate::PreSandboxStartup() {
#else #else
if (command_line.HasSwitch(::switches::kEnableLogging)) if (command_line.HasSwitch(::switches::kEnableLogging))
InitLogging(command_line); InitLogging(command_line);
#endif // defined(OS_WIN)
// Initializing the crash reporter fails in multiple ways on Windows. See
// https://crbug.com/1147063
InitCrashReporter(command_line); InitCrashReporter(command_line);
#endif // defined(OS_WIN)
InitializeResourceBundle(command_line); InitializeResourceBundle(command_line);
// Even though InitializeResourceBundle() has indirectly done the locale // Even though InitializeResourceBundle() has indirectly done the locale
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment