Skip to content

GitLab

T
tangled
Commit 309585b9 authored by Esmael El-Moslimany's avatar Esmael El-Moslimany Committed by Commit Bot
Browse files
Options

WebUI: removing paper-radio-group 

This is a follow-up CL to creating an alternative radio group called
cr-radio-group and replacing all usages of paper-radio-group with
cr-radio-group.

Bug: 888922
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I6637190f8eb63409c16ff70f6a7bc65872442780
Reviewed-on: https://chromium-review.googlesource.com/c/1277526
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: default avatarDemetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602249}
parent 066cb5ad
Hide whitespace changes
Inline Side-by-side
Showing with 0 additions and 286 deletions
third_party/polymer/v1_0/bower.json
View file @ 309585b9
......@@ -40,7 +40,6 @@
"paper-item": "PolymerElements/paper-item#2.0.0",
"paper-listbox": "PolymerelEments/paper-listbox#2.0.0",
"paper-progress": "PolymerElements/paper-progress#2.0.1",
"paper-radio-group": "PolymerElements/paper-radio-group#2.1.0",
"paper-ripple": "PolymerElements/paper-ripple#2.0.1",
"paper-slider": "PolymerElements/paper-slider#2.0.2",
"paper-spinner": "PolymerElements/paper-spinner#2.0.0",
......
third_party/polymer/v1_0/chromium.patch
View file @ 309585b9
......@@ -115,18 +115,6 @@ index 43c59653a39b..26652936735c 100644
},
_forwardItemPath: function(path, value) {
diff --git a/components-chromium/paper-radio-group/paper-radio-group.html b/components-chromium/paper-radio-group/paper-radio-group.html
index f50638bf6175..d38cde355822 100644
--- a/components-chromium/paper-radio-group/paper-radio-group.html
+++ b/components-chromium/paper-radio-group/paper-radio-group.html
@@ -9,7 +9,6 @@ subject to an additional IP rights grant found at http://polymer.github.io/PATEN
--><html><head><link rel="import" href="../polymer/polymer.html">
<link rel="import" href="../iron-a11y-keys-behavior/iron-a11y-keys-behavior.html">
<link rel="import" href="../iron-menu-behavior/iron-menubar-behavior.html">
-<link rel="import" href="../paper-radio-button/paper-radio-button.html">
<!--
Material design: [Radio button](https://www.google.com/design/spec/components/selection-controls.html#selection-controls-radio-button)
diff --git a/components-chromium/iron-flex-layout/iron-flex-layout.html b/components-chromium/iron-flex-layout/iron-flex-layout.html
index 082b0c1e4af2..d985829702a2 100644
--- a/components-chromium/iron-flex-layout/iron-flex-layout.html
......
third_party/polymer/v1_0/components-chromium/paper-radio-group/BUILD.gn deleted 100644 → 0
View file @ 066cb5ad
# Copyright 2018 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
#
# NOTE: Created with generate_gn.py, please do not edit.
import("//third_party/closure_compiler/compile_js.gni")
js_library("paper-radio-group-extracted") {
deps = [
"../iron-a11y-keys-behavior:iron-a11y-keys-behavior-extracted",
"../iron-menu-behavior:iron-menubar-behavior-extracted",
]
}
third_party/polymer/v1_0/components-chromium/paper-radio-group/bower.json deleted 100644 → 0
View file @ 066cb5ad
{
"name": "paper-radio-group",
"version": "2.1.0",
"description": "A group of material design radio buttons",
"authors": [
"The Polymer Authors"
],
"keywords": [
"web-components",
"polymer",
"radio",
"control"
],
"private": true,
"repository": {
"type": "git",
"url": "git://github.com/PolymerElements/paper-radio-group.git"
},
"license": "http://polymer.github.io/LICENSE.txt",
"homepage": "https://github.com/PolymerElements/paper-radio-group",
"main": "paper-radio-group.html",
"ignore": [],
"dependencies": {
"polymer": "Polymer/polymer#1.9 - 2",
"iron-a11y-keys-behavior": "PolymerElements/iron-a11y-keys-behavior#1 - 2",
"iron-menu-behavior": "PolymerElements/iron-menu-behavior#1 - 2",
"paper-radio-button": "PolymerElements/paper-radio-button#1 - 2"
},
"devDependencies": {
"iron-component-page": "PolymerElements/iron-component-page#1 - 2",
"iron-demo-helpers": "PolymerElements/iron-demo-helpers#1 - 2",
"iron-test-helpers": "PolymerElements/iron-test-helpers#1 - 2",
"paper-styles": "PolymerElements/paper-styles#1 - 2",
"web-component-tester": "^6.0.0",
"webcomponentsjs": "webcomponents/webcomponentsjs#^1.0.0"
},
"variants": {
"1.x": {
"dependencies": {
"polymer": "Polymer/polymer#^1.9",
"iron-a11y-keys-behavior": "PolymerElements/iron-a11y-keys-behavior#^1.0.0",
"iron-menu-behavior": "PolymerElements/iron-menu-behavior#^1.1.7",
"paper-radio-button": "PolymerElements/paper-radio-button#^1.0.0"
},
"devDependencies": {
"iron-component-page": "PolymerElements/iron-component-page#^1.0.0",
"iron-demo-helpers": "PolymerElements/iron-demo-helpers#^1.0.0",
"iron-test-helpers": "PolymerElements/iron-test-helpers#^1.0.0",
"paper-styles": "PolymerElements/paper-styles#^1.0.0",
"web-component-tester": "^4.0.0",
"webcomponentsjs": "webcomponents/webcomponentsjs#^0.7.0"
},
"resolutions": {
"webcomponentsjs": "^0.7"
}
}
},
"resolutions": {
"webcomponentsjs": "^1.0.0"
}
}
third_party/polymer/v1_0/components-chromium/paper-radio-group/paper-radio-group-extracted.js deleted 100644 → 0
View file @ 066cb5ad
Polymer({
is: 'paper-radio-group',
behaviors: [
Polymer.IronMenubarBehavior
],
hostAttributes: {
role: 'radiogroup',
},
properties: {
/**
* Fired when the radio group selection changes.
*
* @event paper-radio-group-changed
*/
/**
* Overriden from Polymer.IronSelectableBehavior
*/
attrForSelected: {
type: String,
value: 'name'
},
/**
* Overriden from Polymer.IronSelectableBehavior
*/
selectedAttribute: {
type: String,
value: 'checked'
},
/**
* Overriden from Polymer.IronSelectableBehavior
*/
selectable: {
type: String,
value: 'paper-radio-button'
},
/**
* If true, radio-buttons can be deselected
*/
allowEmptySelection: {
type: Boolean,
value: false
}
},
/**
* Selects the given value.
*/
select: function(value) {
var newItem = this._valueToItem(value);
if (newItem && newItem.hasAttribute('disabled')) {
return;
}
if (this.selected) {
var oldItem = this._valueToItem(this.selected);
if (this.selected == value) {
// If deselecting is allowed we'll have to apply an empty selection.
// Otherwise, we should force the selection to stay and make this
// action a no-op.
if (this.allowEmptySelection) {
value = '';
} else {
if (oldItem)
oldItem.checked = true;
return;
}
}
if (oldItem)
oldItem.checked = false;
}
Polymer.IronSelectableBehavior.select.apply(this, [value]);
this.fire('paper-radio-group-changed');
},
_activateFocusedItem: function() {
this._itemActivate(this._valueForItem(this.focusedItem), this.focusedItem);
},
_onUpKey: function(event) {
this._focusPrevious();
event.preventDefault();
this._activateFocusedItem();
},
_onDownKey: function(event) {
this._focusNext();
event.preventDefault();
this._activateFocusedItem();
},
_onLeftKey: function(event) {
Polymer.IronMenubarBehaviorImpl._onLeftKey.apply(this, arguments);
this._activateFocusedItem();
},
_onRightKey: function(event) {
Polymer.IronMenubarBehaviorImpl._onRightKey.apply(this, arguments);
this._activateFocusedItem();
}
});
\ No newline at end of file
third_party/polymer/v1_0/components-chromium/paper-radio-group/paper-radio-group.html deleted 100644 → 0
View file @ 066cb5ad
<!--
@license
Copyright (c) 2015 The Polymer Project Authors. All rights reserved.
This code may only be used under the BSD style license found at http://polymer.github.io/LICENSE.txt
The complete set of authors may be found at http://polymer.github.io/AUTHORS.txt
The complete set of contributors may be found at http://polymer.github.io/CONTRIBUTORS.txt
Code distributed by Google as part of the polymer project is also
subject to an additional IP rights grant found at http://polymer.github.io/PATENTS.txt
--><html><head><link rel="import" href="../polymer/polymer.html">
<link rel="import" href="../iron-a11y-keys-behavior/iron-a11y-keys-behavior.html">
<link rel="import" href="../iron-menu-behavior/iron-menubar-behavior.html">
<!--
Material design: [Radio button](https://www.google.com/design/spec/components/selection-controls.html#selection-controls-radio-button)
`paper-radio-group` allows user to select at most one radio button from a set.
Checking one radio button that belongs to a radio group unchecks any
previously checked radio button within the same group. Use
`selected` to get or set the selected radio button.
The <paper-radio-buttons> inside the group must have the `name` attribute
set.
Example:
<paper-radio-group selected="small">
<paper-radio-button name="small">Small</paper-radio-button>
<paper-radio-button name="medium">Medium</paper-radio-button>
<paper-radio-button name="large">Large</paper-radio-button>
</paper-radio-group>
Radio-button-groups can be made optional, and allow zero buttons to be selected:
<paper-radio-group selected="small" allow-empty-selection>
<paper-radio-button name="small">Small</paper-radio-button>
<paper-radio-button name="medium">Medium</paper-radio-button>
<paper-radio-button name="large">Large</paper-radio-button>
</paper-radio-group>
See <a href="paper-radio-button">paper-radio-button</a> for more
information about `paper-radio-button`.
Custom property | Description | Default
----------------|-------------|----------
`--paper-radio-group-item-padding` | The padding of the item | `12px`
@group Paper Elements
@element paper-radio-group
@hero hero.svg
@demo demo/index.html
-->
</head><body><dom-module id="paper-radio-group">
<template>
<style>
:host {
display: inline-block;
}
:host ::slotted(*) {
padding: var(--paper-radio-group-item-padding, 12px);
}
</style>
<slot></slot>
</template>
</dom-module>
<script src="paper-radio-group-extracted.js"></script></body></html>
\ No newline at end of file
third_party/polymer/v1_0/components_summary.txt
View file @ 309585b9
......@@ -226,12 +226,6 @@ Tree: v2.0.1
Revision: abe7b27bb1651e1adac99d9878a4c87cd9b40d7d
Tree link: https://github.com/PolymerElements/paper-progress/tree/v2.0.1
Name: paper-radio-group
Repository: https://github.com/PolymerElements/paper-radio-group.git
Tree: v2.1.0
Revision: 0d87ce662f6d86b0343cd929ab9f503dc126c764
Tree link: https://github.com/PolymerElements/paper-radio-group/tree/v2.1.0
Name: paper-ripple
Repository: https://github.com/PolymerElements/paper-ripple.git
Tree: v2.0.1
......
third_party/polymer/v1_0/rsync_exclude.txt
View file @ 309585b9
......@@ -28,10 +28,6 @@ package-lock.json
*/site/
*/templates/
# This is downloaded even though it's unused due to http://crbug.com/843701#c1
# paper-radio-button
paper-radio-button/
# paper-spinner
paper-spinner/paper-spinner.html
......
ui/webui/resources/polymer_resources.grdp
View file @ 309585b9
......@@ -672,14 +672,6 @@
file="../../../third_party/polymer/v1_0/components-chromium/paper-progress/paper-progress.html"
type="chrome_html"
compress="gzip" />
<structure name="IDR_POLYMER_1_0_PAPER_RADIO_GROUP_PAPER_RADIO_GROUP_EXTRACTED_JS"
file="../../../third_party/polymer/v1_0/components-chromium/paper-radio-group/paper-radio-group-extracted.js"
type="chrome_html"
compress="gzip" />
<structure name="IDR_POLYMER_1_0_PAPER_RADIO_GROUP_PAPER_RADIO_GROUP_HTML"
file="../../../third_party/polymer/v1_0/components-chromium/paper-radio-group/paper-radio-group.html"
type="chrome_html"
compress="gzip" />
<structure name="IDR_POLYMER_1_0_PAPER_RIPPLE_PAPER_RIPPLE_EXTRACTED_JS"
file="../../../third_party/polymer/v1_0/components-chromium/paper-ripple/paper-ripple-extracted.js"
type="chrome_html"
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment