Commit 30aa3e3f authored by Dirk Pranke's avatar Dirk Pranke Committed by Commit Bot

Pass defines to grit when computing inputs for analyze.

When running `mb analyze` on the builders, we want to make
sure we correctly catch changes to files included by grit
but not explicitly mentioned as inputs in the BUILD.gn files.
Unfortunately, we weren't passing along the -D flags we're
using to actually run grit, and so we were not catching the
files that are conditionally included.

R=ddorwin@chromium.org
BUG=862731

Change-Id: I68b98e5786a2dd44e9ee5404aa4de3b0b1feaf33
Reviewed-on: https://chromium-review.googlesource.com/1150612Reviewed-by: default avatarDavid Dorwin <ddorwin@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578102}
parent 144f3664
...@@ -409,7 +409,7 @@ template("grit") { ...@@ -409,7 +409,7 @@ template("grit") {
grit_info_args = [ grit_info_args = [
"--inputs", "--inputs",
source_path, source_path,
] + grit_flags + grit_defines ] + grit_flags + grit_defines + define_args
# Only call exec_script when the user has explicitly opted into greater # Only call exec_script when the user has explicitly opted into greater
# precision at the expense of performance. # precision at the expense of performance.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment