Fix the issue causing dinner for one results not showing up.

The problem is SearchResult kept its own property of is_recommendation_,
instead of using metadata_'s is_recommendation attribute.Therefore, it
is out of sync of ArcAppReinstallAppResult for its is_recommendation setting.

Bug: 1050761
Change-Id: Id5d503b0541626ccfdde7b7a9b8dbc3784cfe655
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090835Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Jenny Zhang <jennyz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748449}

ash/app_list/model/search/search_result.h

@@ -152,9 +152,9 @@ class APP_LIST_MODEL_EXPORT SearchResult {
   bool is_visible() const { return is_visible_; }
   void set_is_visible(bool is_visible) { is_visible_ = is_visible; }
 
-  bool is_recommendation() const { return is_recommendation_; }
+  bool is_recommendation() const { return metadata_->is_recommendation; }
   void set_is_recommendation(bool is_recommendation) {
-    is_recommendation_ = is_recommendation;
+    metadata_->is_recommendation = is_recommendation;
   }
 
   void NotifyItemInstalled();
@@ -189,7 +189,6 @@ class APP_LIST_MODEL_EXPORT SearchResult {
   bool is_installing_ = false;
   int percent_downloaded_ = 0;
   bool is_visible_ = true;
-  bool is_recommendation_ = false;
 
   std::unique_ptr<SearchResultMetadata> metadata_;
 

ash/app_list/views/search_result_tile_item_list_view.cc

@@ -274,6 +274,10 @@ std::vector<SearchResult*> SearchResultTileItemListView::GetDisplayResults() {
 
   // We ask for |max_search_result_tiles_| policy tile results first,
   // then add them to their preferred position in the tile list if found.
+  // Note: Policy tile provides a mechanism to display the result tile at the
+  // preferred position recommended by display_index() property of the search
+  // result. This is what policy referred to. It has nothing to do with
+  // Enterprise policy.
   auto policy_tiles_filter =
       base::BindRepeating([](const SearchResult& r) -> bool {
         return r.display_index() != SearchResultDisplayIndex::kUndefined &&