Commit 312d026c authored by Olesia Marukhno's avatar Olesia Marukhno Committed by Chromium LUCI CQ

Remove PermissionBubbleBrowserTest test suite for Cocoa browser window

This suite tests the Views bubble with the Cocoa browser window, but we
haven't supported that configuration in over a year.

Bug: 1148277
Change-Id: I5d4ceda74d7c15ae0df9eaa619b29e50a4a934ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550812Reviewed-by: default avatarElly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: default avatarBret Sepulveda <bsep@chromium.org>
Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com>
Cr-Commit-Position: refs/heads/master@{#832304}
parent 98dd7cc3
estark@chromium.org
felt@chromium.org
rsesek@chromium.org
// Copyright 2015 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <memory>
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_commands_mac.h"
#include "chrome/browser/ui/browser_finder.h"
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/exclusive_access/exclusive_access_context.h"
#include "chrome/browser/ui/exclusive_access/exclusive_access_test.h"
#include "chrome/browser/ui/exclusive_access/fullscreen_controller.h"
#include "chrome/browser/ui/permission_bubble/permission_bubble_browser_test_util.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/browser/ui/views/permission_bubble/permission_prompt_impl.h"
#include "chrome/test/permissions/permission_request_manager_test_api.h"
#include "content/public/test/browser_test.h"
#import "testing/gtest_mac.h"
#include "ui/base/test/scoped_fake_nswindow_fullscreen.h"
// This file now tests the views permission bubble, on a Cocoa browser window.
namespace {
// Shows a test bubble using the permission request manager rather than any
// toolkit-specific bubble implementation.
void ShowBubble(Browser* browser) {
auto test_api =
std::make_unique<test::PermissionRequestManagerTestApi>(browser);
EXPECT_TRUE(test_api->manager());
test_api->AddSimpleRequest(
browser->tab_strip_model()->GetActiveWebContents()->GetMainFrame(),
ContentSettingsType::GEOLOCATION);
// The PermissionRequestManager displays prompts asynchronously.
EXPECT_FALSE(test_api->GetPromptWindow());
base::RunLoop().RunUntilIdle();
EXPECT_TRUE(test_api->GetPromptWindow());
}
bool HasVisibleLocationBarForBrowser(Browser* browser) {
return browser->SupportsWindowFeature(Browser::FEATURE_LOCATIONBAR);
}
} // namespace
IN_PROC_BROWSER_TEST_F(PermissionBubbleBrowserTest, HasLocationBarByDefault) {
ShowBubble(browser());
HasVisibleLocationBarForBrowser(browser());
}
IN_PROC_BROWSER_TEST_F(PermissionBubbleBrowserTest,
TabFullscreenHasNoLocationBar) {
ShowBubble(browser());
EXPECT_TRUE(HasVisibleLocationBarForBrowser(browser()));
FullscreenController* controller =
browser()->exclusive_access_manager()->fullscreen_controller();
{
FullscreenNotificationObserver fullscreen_observer(browser());
controller->EnterFullscreenModeForTab(
browser()->tab_strip_model()->GetActiveWebContents()->GetMainFrame());
fullscreen_observer.Wait();
}
EXPECT_TRUE(controller->IsTabFullscreen());
EXPECT_FALSE(HasVisibleLocationBarForBrowser(browser()));
{
FullscreenNotificationObserver fullscreen_observer(browser());
controller->ExitFullscreenModeForTab(
browser()->tab_strip_model()->GetActiveWebContents());
fullscreen_observer.Wait();
}
EXPECT_FALSE(controller->IsTabFullscreen());
EXPECT_TRUE(HasVisibleLocationBarForBrowser(browser()));
}
IN_PROC_BROWSER_TEST_F(PermissionBubbleBrowserTest, AppHasNoLocationBar) {
content::WebContents* app_contents = OpenExtensionAppWindow();
Browser* app_browser = chrome::FindBrowserWithWebContents(app_contents);
ASSERT_TRUE(app_browser->is_type_app());
// ShowBubble(app_browser) doesn't actually show a bubble for extension app
// windows, so create one directly.
auto prompt = std::make_unique<PermissionPromptImpl>(
app_browser, app_contents, test_delegate());
EXPECT_FALSE(HasVisibleLocationBarForBrowser(app_browser));
}
IN_PROC_BROWSER_TEST_F(PermissionBubbleKioskBrowserTest,
KioskHasNoLocationBar) {
ShowBubble(browser());
// Kiosk mode on Mac has no location bar.
EXPECT_FALSE(HasVisibleLocationBarForBrowser(browser()));
}
...@@ -2959,7 +2959,6 @@ if (!is_android) { ...@@ -2959,7 +2959,6 @@ if (!is_android) {
"../browser/ui/cocoa/apps/app_shim_menu_controller_mac_browsertest.mm", "../browser/ui/cocoa/apps/app_shim_menu_controller_mac_browsertest.mm",
"../browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm", "../browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm",
"../browser/ui/cocoa/browser_window_mac_browsertest.mm", "../browser/ui/cocoa/browser_window_mac_browsertest.mm",
"../browser/ui/cocoa/permission_bubble/permission_bubble_views_cocoa_browsertest.mm",
"../browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac_cocoa_browsertest.mm", "../browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac_cocoa_browsertest.mm",
"../browser/ui/cocoa/share_menu_controller_browsertest.mm", "../browser/ui/cocoa/share_menu_controller_browsertest.mm",
"../browser/ui/cocoa/task_manager_mac_browsertest.mm", "../browser/ui/cocoa/task_manager_mac_browsertest.mm",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment